Changeset b7fd2a0 in mainline for uspace/lib/c/include/ddi.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/include/ddi.h (modified) (1 diff)

uspace/lib/c/include/ddi.h

@@ -54 +54 @@
 typedef volatile uint64_t ioport64_t;
 
-extern int physmem_map(uintptr_t, size_t, unsigned int, void **);
-extern int physmem_unmap(void *);
+extern errno_t physmem_map(uintptr_t, size_t, unsigned int, void **);
+extern errno_t physmem_unmap(void *);
 
-extern int dmamem_map(void *, size_t, unsigned int, unsigned int, uintptr_t *);
-extern int dmamem_map_anonymous(size_t, uintptr_t, unsigned int, unsigned int,
+extern errno_t dmamem_map(void *, size_t, unsigned int, unsigned int, uintptr_t *);
+extern errno_t dmamem_map_anonymous(size_t, uintptr_t, unsigned int, unsigned int,
     uintptr_t *, void **);
-extern int dmamem_unmap(void *, size_t);
-extern int dmamem_unmap_anonymous(void *);
+extern errno_t dmamem_unmap(void *, size_t);
+extern errno_t dmamem_unmap_anonymous(void *);
 
-extern int pio_enable_range(addr_range_t *, void **);
-extern int pio_enable_resource(pio_window_t *, hw_resource_t *, void **);
-extern int pio_enable(void *, size_t, void **);
-extern int pio_disable(void *, size_t);
+extern errno_t pio_enable_range(addr_range_t *, void **);
+extern errno_t pio_enable_resource(pio_window_t *, hw_resource_t *, void **);
+extern errno_t pio_enable(void *, size_t, void **);
+extern errno_t pio_disable(void *, size_t);
 
 typedef void (*trace_fnc)(const volatile void *place, uint64_t val,
     volatile void* base, size_t size, void *data, bool write);
 
-extern int pio_trace_enable(void *, size_t, trace_fnc, void *);
+extern errno_t pio_trace_enable(void *, size_t, trace_fnc, void *);
 extern void pio_trace_log(const volatile void *, uint64_t val, bool write);
 extern void pio_trace_disable(void *);