Changeset b7fd2a0 in mainline for uspace/lib/c/generic/io/serial.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/io/serial.c (modified) (4 diffs)

uspace/lib/c/generic/io/serial.c

@@ -41 +41 @@
  * @return EOK on success, ENOMEM if out of memory, EIO on I/O error
  */
-int serial_open(async_sess_t *sess, serial_t **rserial)
+errno_t serial_open(async_sess_t *sess, serial_t **rserial)
 {
         serial_t *serial;
@@ -68 +68 @@
 
 /** Set serial port communication properties. */
-int serial_set_comm_props(serial_t *serial, unsigned rate,
+errno_t serial_set_comm_props(serial_t *serial, unsigned rate,
     serial_parity_t parity, unsigned datab, unsigned stopb)
 {
         async_exch_t *exch = async_exchange_begin(serial->sess);
 
-        int rc = async_req_4_0(exch, SERIAL_SET_COM_PROPS, rate, parity,
+        errno_t rc = async_req_4_0(exch, SERIAL_SET_COM_PROPS, rate, parity,
             datab, stopb);
 
@@ -81 +81 @@
 
 /** Get serial port communication properties. */
-int serial_get_comm_props(serial_t *serial, unsigned *rrate,
+errno_t serial_get_comm_props(serial_t *serial, unsigned *rrate,
     serial_parity_t *rparity, unsigned *rdatab, unsigned *rstopb)
 {
@@ -87 +87 @@
         sysarg_t rate, parity, datab, stopb;
 
-        int rc = async_req_0_4(exch, SERIAL_GET_COM_PROPS, &rate, &parity,
+        errno_t rc = async_req_0_4(exch, SERIAL_GET_COM_PROPS, &rate, &parity,
             &datab, &stopb);