Changeset b7fd2a0 in mainline for uspace/lib/c/generic/io/con_srv.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/io/con_srv.c (modified) (8 diffs)

uspace/lib/c/generic/io/con_srv.c

@@ -42 +42 @@
 #include <io/con_srv.h>
 
-static int console_ev_encode(cons_event_t *event, ipc_call_t *call)
+static errno_t console_ev_encode(cons_event_t *event, ipc_call_t *call)
 {
         IPC_SET_ARG1(*call, event->type);
@@ -71 +71 @@
         void *buf;
         size_t size;
-        int rc;
+        errno_t rc;
         ipc_callid_t rcallid;
 
@@ -113 +113 @@
         void *data;
         size_t size;
-        int rc;
+        errno_t rc;
 
         rc = async_data_write_accept(&data, false, 0, 0, 0, &size);
@@ -178 +178 @@
     ipc_call_t *call)
 {
-        int rc;
+        errno_t rc;
         sysarg_t col;
         sysarg_t row;
@@ -194 +194 @@
     ipc_call_t *call)
 {
-        int rc;
+        errno_t rc;
         sysarg_t cols;
         sysarg_t rows;
@@ -210 +210 @@
     ipc_call_t *call)
 {
-        int rc;
+        errno_t rc;
         console_caps_t ccap;
 
@@ -295 +295 @@
     ipc_call_t *call)
 {
-        int rc;
+        errno_t rc;
         cons_event_t event;
         ipc_call_t result;
@@ -340 +340 @@
 }
 
-int con_conn(ipc_callid_t iid, ipc_call_t *icall, con_srvs_t *srvs)
+errno_t con_conn(ipc_callid_t iid, ipc_call_t *icall, con_srvs_t *srvs)
 {
         con_srv_t *srv;
-        int rc;
+        errno_t rc;
 
         /* Accept the connection */