Changeset b7fd2a0 in mainline for uspace/lib/c/generic/inetping.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/inetping.c (modified) (9 diffs)

uspace/lib/c/generic/inetping.c

@@ -44 +44 @@
 static inetping_ev_ops_t *inetping_ev_ops;
 
-int inetping_init(inetping_ev_ops_t *ev_ops)
+errno_t inetping_init(inetping_ev_ops_t *ev_ops)
 {
         service_id_t inetping_svc;
-        int rc;
+        errno_t rc;
 
         assert(inetping_sess == NULL);
@@ -80 +80 @@
 }
 
-int inetping_send(inetping_sdu_t *sdu)
+errno_t inetping_send(inetping_sdu_t *sdu)
 {
         async_exch_t *exch = async_exchange_begin(inetping_sess);
@@ -87 +87 @@
         aid_t req = async_send_1(exch, INETPING_SEND, sdu->seq_no, &answer);
 
-        int rc = async_data_write_start(exch, &sdu->src, sizeof(sdu->src));
+        errno_t rc = async_data_write_start(exch, &sdu->src, sizeof(sdu->src));
         if (rc != EOK) {
                 async_exchange_end(exch);
@@ -110 +110 @@
         }
 
-        int retval;
+        errno_t retval;
         async_wait_for(req, &retval);
 
@@ -116 +116 @@
 }
 
-int inetping_get_srcaddr(const inet_addr_t *remote, inet_addr_t *local)
+errno_t inetping_get_srcaddr(const inet_addr_t *remote, inet_addr_t *local)
 {
         async_exch_t *exch = async_exchange_begin(inetping_sess);
@@ -123 +123 @@
         aid_t req = async_send_0(exch, INETPING_GET_SRCADDR, &answer);
 
-        int rc = async_data_write_start(exch, remote, sizeof(*remote));
+        errno_t rc = async_data_write_start(exch, remote, sizeof(*remote));
         if (rc != EOK) {
                 async_exchange_end(exch);
@@ -136 +136 @@
         async_exchange_end(exch);
 
-        int retval_local;
+        errno_t retval_local;
         async_wait_for(req_local, &retval_local);
 
@@ -144 +144 @@
         }
 
-        int retval;
+        errno_t retval;
         async_wait_for(req, &retval);
 
@@ -170 +170 @@
         }
 
-        int rc = async_data_write_finalize(callid, &sdu.src, size);
+        errno_t rc = async_data_write_finalize(callid, &sdu.src, size);
         if (rc != EOK) {
                 async_answer_0(callid, rc);