Changeset b7fd2a0 in mainline for uspace/lib/c/generic/inet/hostport.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/inet/hostport.c (modified) (5 diffs)

uspace/lib/c/generic/inet/hostport.c

@@ -56 +56 @@
  *         extra characters at the end. ENOMEM if out of memory
  */
-int inet_hostport_parse(const char *str, inet_hostport_t **rhp,
+errno_t inet_hostport_parse(const char *str, inet_hostport_t **rhp,
     char **endptr)
 {
@@ -65 +65 @@
         char *aend;
         const char *pend;
-        int rc;
+        errno_t rc;
 
         hp = calloc(1, sizeof(inet_hostport_t));
@@ -137 +137 @@
  * @return EOK on success, ENOMEM if out of memory
  */
-int inet_hostport_format(inet_hostport_t *hp, char **rstr)
-{
-        int rc;
+errno_t inet_hostport_format(inet_hostport_t *hp, char **rstr)
+{
+        errno_t rc;
         int ret;
         char *astr, *str;
@@ -211 +211 @@
  * @return EOK on success, ENOENT on resolution failure
  */
-int inet_hostport_lookup_one(inet_hostport_t *hp, ip_ver_t version,
+errno_t inet_hostport_lookup_one(inet_hostport_t *hp, ip_ver_t version,
     inet_ep_t *ep)
 {
         dnsr_hostinfo_t *hinfo = NULL;
-        int rc;
+        errno_t rc;
 
         inet_ep_init(ep);
@@ -255 +255 @@
  *         ENOMEM if out of memory
  */
-int inet_hostport_plookup_one(const char *str, ip_ver_t version, inet_ep_t *ep,
+errno_t inet_hostport_plookup_one(const char *str, ip_ver_t version, inet_ep_t *ep,
     char **endptr, const char **errmsg)
 {
         inet_hostport_t *hp = NULL;
         char *eptr;
-        int rc;
+        errno_t rc;
 
         rc = inet_hostport_parse(str, &hp, endptr != NULL ? &eptr : NULL);