Changeset b7fd2a0 in mainline for uspace/lib/c/generic/event.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/event.c (modified) (6 diffs)

uspace/lib/c/generic/event.c

@@ -48 +48 @@
  *
  */
-int ipc_event_subscribe(event_type_t evno, sysarg_t imethod)
+errno_t ipc_event_subscribe(event_type_t evno, sysarg_t imethod)
 {
-        return (int) __SYSCALL2(SYS_IPC_EVENT_SUBSCRIBE, (sysarg_t) evno,
+        return (errno_t) __SYSCALL2(SYS_IPC_EVENT_SUBSCRIBE, (sysarg_t) evno,
             (sysarg_t) imethod);
 }
@@ -62 +62 @@
  *
  */
-int ipc_event_task_subscribe(event_task_type_t evno, sysarg_t imethod)
+errno_t ipc_event_task_subscribe(event_task_type_t evno, sysarg_t imethod)
 {
-        return (int) __SYSCALL2(SYS_IPC_EVENT_SUBSCRIBE, (sysarg_t) evno,
+        return (errno_t) __SYSCALL2(SYS_IPC_EVENT_SUBSCRIBE, (sysarg_t) evno,
             (sysarg_t) imethod);
 }
@@ -75 +75 @@
  *
  */
-int ipc_event_unsubscribe(event_type_t evno)
+errno_t ipc_event_unsubscribe(event_type_t evno)
 {
-        return (int) __SYSCALL1(SYS_IPC_EVENT_UNSUBSCRIBE, (sysarg_t) evno);
+        return (errno_t) __SYSCALL1(SYS_IPC_EVENT_UNSUBSCRIBE, (sysarg_t) evno);
 }
 
@@ -87 +87 @@
  *
  */
-int ipc_event_task_unsubscribe(event_task_type_t evno)
+errno_t ipc_event_task_unsubscribe(event_task_type_t evno)
 {
-        return (int) __SYSCALL1(SYS_IPC_EVENT_UNSUBSCRIBE, (sysarg_t) evno);
+        return (errno_t) __SYSCALL1(SYS_IPC_EVENT_UNSUBSCRIBE, (sysarg_t) evno);
 }
 
@@ -99 +99 @@
  *
  */
-int ipc_event_unmask(event_type_t evno)
+errno_t ipc_event_unmask(event_type_t evno)
 {
-        return (int) __SYSCALL1(SYS_IPC_EVENT_UNMASK, (sysarg_t) evno);
+        return (errno_t) __SYSCALL1(SYS_IPC_EVENT_UNMASK, (sysarg_t) evno);
 }
 
@@ -111 +111 @@
  *
  */
-int ipc_event_task_unmask(event_task_type_t evno)
+errno_t ipc_event_task_unmask(event_task_type_t evno)
 {
-        return (int) __SYSCALL1(SYS_IPC_EVENT_UNMASK, (sysarg_t) evno);
+        return (errno_t) __SYSCALL1(SYS_IPC_EVENT_UNMASK, (sysarg_t) evno);
 }