Changeset b7fd2a0 in mainline for uspace/lib/c/generic/elf/elf_mod.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/elf/elf_mod.c (modified) (4 diffs)

uspace/lib/c/generic/elf/elf_mod.c

@@ -99 +99 @@
 
         int ofile;
-        int rc = vfs_clone(file, -1, true, &ofile);
+        errno_t rc = vfs_clone(file, -1, true, &ofile);
         if (rc == EOK) {
                 rc = vfs_open(ofile, MODE_READ);
@@ -121 +121 @@
 {
         int file;
-        int rc = vfs_lookup(path, 0, &file);
+        errno_t rc = vfs_lookup(path, 0, &file);
         if (rc == EOK) {
                 int ret = elf_load_file(file, so_bias, flags, info);
@@ -148 +148 @@
         size_t nr;
         int i, ret;
-        int rc;
+        errno_t rc;
 
         rc = vfs_read(elf->fd, &pos, header, sizeof(elf_header_t), &nr);
@@ -341 +341 @@
         size_t mem_sz;
         aoff64_t pos;
-        int rc;
+        errno_t rc;
         size_t nr;