Changeset b7fd2a0 in mainline for uspace/lib/c/generic/dhcp.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/dhcp.c (modified) (4 diffs)

uspace/lib/c/generic/dhcp.c

@@ -44 +44 @@
 static async_sess_t *dhcp_sess = NULL;
 
-int dhcp_init(void)
+errno_t dhcp_init(void)
 {
         service_id_t dhcp_svc;
-        int rc;
+        errno_t rc;
 
         assert(dhcp_sess == NULL);
@@ -64 +64 @@
 }
 
-int dhcp_link_add(sysarg_t link_id)
+errno_t dhcp_link_add(sysarg_t link_id)
 {
         async_exch_t *exch = async_exchange_begin(dhcp_sess);
 
-        int rc = async_req_1_0(exch, DHCP_LINK_ADD, link_id);
+        errno_t rc = async_req_1_0(exch, DHCP_LINK_ADD, link_id);
         async_exchange_end(exch);
 
@@ -74 +74 @@
 }
 
-int dhcp_link_remove(sysarg_t link_id)
+errno_t dhcp_link_remove(sysarg_t link_id)
 {
         async_exch_t *exch = async_exchange_begin(dhcp_sess);
 
-        int rc = async_req_1_0(exch, DHCP_LINK_REMOVE, link_id);
+        errno_t rc = async_req_1_0(exch, DHCP_LINK_REMOVE, link_id);
         async_exchange_end(exch);
 
@@ -84 +84 @@
 }
 
-int dhcp_discover(sysarg_t link_id)
+errno_t dhcp_discover(sysarg_t link_id)
 {
         async_exch_t *exch = async_exchange_begin(dhcp_sess);
 
-        int rc = async_req_1_0(exch, DHCP_DISCOVER, link_id);
+        errno_t rc = async_req_1_0(exch, DHCP_DISCOVER, link_id);
         async_exchange_end(exch);