Changeset b7fd2a0 in mainline for uspace/lib/c/generic/corecfg.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/corecfg.c (modified) (3 diffs)

uspace/lib/c/generic/corecfg.c

@@ -38 +38 @@
 static async_sess_t *corecfg_sess = NULL;
 
-int corecfg_init(void)
+errno_t corecfg_init(void)
 {
         service_id_t corecfg_svc;
-        int rc;
+        errno_t rc;
 
         assert(corecfg_sess == NULL);
@@ -59 +59 @@
 
 /** Get core dump enable status. */
-int corecfg_get_enable(bool *renable)
+errno_t corecfg_get_enable(bool *renable)
 {
         async_exch_t *exch = async_exchange_begin(corecfg_sess);
         sysarg_t enable;
 
-        int rc = async_req_0_1(exch, CORECFG_GET_ENABLE, &enable);
+        errno_t rc = async_req_0_1(exch, CORECFG_GET_ENABLE, &enable);
 
         async_exchange_end(exch);
@@ -76 +76 @@
 
 /** Enable or disable core dumps. */
-int corecfg_set_enable(bool enable)
+errno_t corecfg_set_enable(bool enable)
 {
         async_exch_t *exch = async_exchange_begin(corecfg_sess);
-        int rc = async_req_1_0(exch, CORECFG_SET_ENABLE, (sysarg_t) enable);
+        errno_t rc = async_req_1_0(exch, CORECFG_SET_ENABLE, (sysarg_t) enable);
 
         async_exchange_end(exch);