Changeset b7fd2a0 in mainline for uspace/drv/char/pl050/pl050.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/char/pl050/pl050.c (modified) (8 diffs)

uspace/drv/char/pl050/pl050.c

@@ -51 +51 @@
 };
 
-static int pl050_dev_add(ddf_dev_t *);
-static int pl050_fun_online(ddf_fun_t *);
-static int pl050_fun_offline(ddf_fun_t *);
+static errno_t pl050_dev_add(ddf_dev_t *);
+static errno_t pl050_fun_online(ddf_fun_t *);
+static errno_t pl050_fun_offline(ddf_fun_t *);
 static void pl050_char_conn(ipc_callid_t, ipc_call_t *, void *);
-static int pl050_read(chardev_srv_t *, void *, size_t, size_t *);
-static int pl050_write(chardev_srv_t *, const void *, size_t, size_t *);
+static errno_t pl050_read(chardev_srv_t *, void *, size_t, size_t *);
+static errno_t pl050_write(chardev_srv_t *, const void *, size_t, size_t *);
 
 static driver_ops_t driver_ops = {
@@ -158 +158 @@
 }
 
-static int pl050_init(pl050_t *pl050)
+static errno_t pl050_init(pl050_t *pl050)
 {
         hw_res_list_parsed_t res;
         void *regs;
-        int rc;
+        errno_t rc;
 
         fibril_mutex_initialize(&pl050->buf_lock);
@@ -237 +237 @@
 }
 
-static int pl050_read(chardev_srv_t *srv, void *buffer, size_t size,
+static errno_t pl050_read(chardev_srv_t *srv, void *buffer, size_t size,
     size_t *nread)
 {
@@ -263 +263 @@
 }
 
-static int pl050_write(chardev_srv_t *srv, const void *data, size_t size,
+static errno_t pl050_write(chardev_srv_t *srv, const void *data, size_t size,
     size_t *nwritten)
 {
@@ -294 +294 @@
 
 /** Add device. */
-static int pl050_dev_add(ddf_dev_t *dev)
+static errno_t pl050_dev_add(ddf_dev_t *dev)
 {
         ddf_fun_t *fun_a;
         pl050_t *pl050 = NULL;
         const char *mname;
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_DEBUG, "pl050_dev_add()");
@@ -363 +363 @@
 }
 
-static int pl050_fun_online(ddf_fun_t *fun)
+static errno_t pl050_fun_online(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "pl050_fun_online()");
@@ -369 +369 @@
 }
 
-static int pl050_fun_offline(ddf_fun_t *fun)
+static errno_t pl050_fun_offline(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "pl050_fun_offline()");
@@ -377 +377 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
 
         printf(NAME ": HelenOS pl050 serial device driver\n");