Changeset b7fd2a0 in mainline for uspace/app/sbi/src/input.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/sbi/src/input.c (modified) (6 diffs)

uspace/app/sbi/src/input.c

@@ -45 +45 @@
 #define INPUT_BUFFER_SIZE 256
 
-static int input_init_file(input_t *input, const char *fname);
+static errno_t input_init_file(input_t *input, const char *fname);
 static void input_init_interactive(input_t *input);
 static void input_init_string(input_t *input, const char *str);
@@ -57 +57 @@
  *                      ENOENT when opening file fails.
  */
-int input_new_file(input_t **input, const char *fname)
+errno_t input_new_file(input_t **input, const char *fname)
 {
         *input = malloc(sizeof(input_t));
@@ -71 +71 @@
  * @return              EOK on success, ENOMEM when allocation fails.
  */
-int input_new_interactive(input_t **input)
+errno_t input_new_interactive(input_t **input)
 {
         *input = malloc(sizeof(input_t));
@@ -87 +87 @@
  * @return              EOK on success, ENOMEM when allocation fails.
  */
-int input_new_string(input_t **input, const char *str)
+errno_t input_new_string(input_t **input, const char *str)
 {
         *input = malloc(sizeof(input_t));
@@ -104 +104 @@
  * @return              EOK on success, ENOENT when opening file fails.
 */
-static int input_init_file(input_t *input, const char *fname)
+static errno_t input_init_file(input_t *input, const char *fname)
 {
         FILE *f;
@@ -174 +174 @@
  * @return              EOK on success, EIO on failure.
  */
-int input_get_line(input_t *input, char **line)
+errno_t input_get_line(input_t *input, char **line)
 {
         const char *prompt;