Changeset b7fd2a0 in mainline for uspace/app/rcutest/rcutest.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/rcutest/rcutest.c (modified) (9 diffs)

uspace/app/rcutest/rcutest.c

@@ -168 +168 @@
 
 
-typedef int (*fibril_func_t)(void *);
-
-static bool create_fibril(int (*func)(void*), void *arg)
+typedef errno_t (*fibril_func_t)(void *);
+
+static bool create_fibril(errno_t (*func)(void*), void *arg)
 {
         fid_t fid = fibril_create(func, arg);
@@ -308 +308 @@
 
 
-static int sleeping_reader(one_reader_info_t *arg)
+static errno_t sleeping_reader(one_reader_info_t *arg)
 {
         rcu_register_fibril();
@@ -390 +390 @@
 
 
-static int preexisting_reader(two_reader_info_t *arg)
+static errno_t preexisting_reader(two_reader_info_t *arg)
 {
         rcu_register_fibril();
@@ -430 +430 @@
 }
 
-static int new_reader(two_reader_info_t *arg)
+static errno_t new_reader(two_reader_info_t *arg)
 {
         rcu_register_fibril();
@@ -551 +551 @@
 
 
-static int exiting_locked_reader(exit_reader_info_t *arg)
+static errno_t exiting_locked_reader(exit_reader_info_t *arg)
 {
         rcu_register_fibril();
@@ -647 +647 @@
 }
 
-static int seq_reader(seq_test_info_t *arg)
+static errno_t seq_reader(seq_test_info_t *arg)
 {
         rcu_register_fibril();
@@ -690 +690 @@
 }
 
-static int seq_updater(seq_test_info_t *arg)
+static errno_t seq_updater(seq_test_info_t *arg)
 {
         rcu_register_fibril();
@@ -779 +779 @@
                 thread_id_t tid;
                 
-                int ret = thread_create(dummy_fibril, NULL, "urcu-test-worker", &tid);
+                errno_t ret = thread_create(dummy_fibril, NULL, "urcu-test-worker", &tid);
                 if (EOK != ret) {
                         printf("Failed to create thread '%zu' (error: %s)\n", k + 1, str_error_name(ret));
@@ -862 +862 @@
         if (argc == 3) {
                 uint32_t thread_cnt = 0;
-                int ret = str_uint32_t(argv[2], NULL, 0, true, &thread_cnt);
+                errno_t ret = str_uint32_t(argv[2], NULL, 0, true, &thread_cnt);
                 
                 if (ret == EOK && 1 <= thread_cnt && thread_cnt <= 64) {