Changeset b7fd2a0 in mainline for uspace/app/pkg/pkg.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/pkg/pkg.c (modified) (5 diffs)

uspace/app/pkg/pkg.c

@@ -49 +49 @@
 }
 
-static int cmd_runl(const char *path, ...)
+static errno_t cmd_runl(const char *path, ...)
 {
         va_list ap;
@@ -65 +65 @@
         task_id_t id;
         task_wait_t wait;
-        int rc = task_spawn(&id, &wait, path, cnt, ap);
+        errno_t rc = task_spawn(&id, &wait, path, cnt, ap);
         va_end(ap);
 
@@ -100 +100 @@
 
 
-static int pkg_install(int argc, char *argv[])
+static errno_t pkg_install(int argc, char *argv[])
 {
         char *pkg_name;
@@ -106 +106 @@
         char *fname;
         char *fnunpack;
-        int rc;
+        errno_t rc;
         int ret;
 
@@ -181 +181 @@
 {
         char *cmd;
-        int rc;
+        errno_t rc;
 
         if (argc < 2) {