Changeset b7fd2a0 in mainline for uspace/app/logset/main.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/logset/main.c (modified) (3 diffs)

uspace/app/logset/main.c

@@ -42 +42 @@
 {
         log_level_t result;
-        int rc = log_level_from_str(log_level, &result);
+        errno_t rc = log_level_from_str(log_level, &result);
         if (rc != EOK) {
                 fprintf(stderr, "Unrecognised log level '%s': %s.\n",
@@ -62 +62 @@
         if (argc == 2) {
                 log_level_t new_default_level = parse_log_level_or_die(argv[1]);
-                int rc = logctl_set_default_level(new_default_level);
+                errno_t rc = logctl_set_default_level(new_default_level);
 
                 if (rc != EOK) {
@@ -72 +72 @@
                 log_level_t new_level = parse_log_level_or_die(argv[2]);
                 const char *logname = argv[1];
-                int rc = logctl_set_log_level(logname, new_level);
+                errno_t rc = logctl_set_log_level(logname, new_level);
 
                 if (rc != EOK) {