Changeset b7fd2a0 in mainline for kernel/generic/src/proc/task.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/proc/task.c (modified) (10 diffs)

kernel/generic/src/proc/task.c

@@ -83 +83 @@
 /* Forward declarations. */
 static void task_kill_internal(task_t *);
-static int tsk_constructor(void *, unsigned int);
+static errno_t tsk_constructor(void *, unsigned int);
 static size_t tsk_destructor(void *obj);
 
@@ -158 +158 @@
 }
 
-int tsk_constructor(void *obj, unsigned int kmflags)
+errno_t tsk_constructor(void *obj, unsigned int kmflags)
 {
         task_t *task = (task_t *) obj;
 
-        int rc = caps_task_alloc(task);
+        errno_t rc = caps_task_alloc(task);
         if (rc != EOK)
                 return rc;
@@ -246 +246 @@
             (container_check(ipc_phone_0->task->container, task->container))) {
                 cap_handle_t phone_handle;
-                int rc = phone_alloc(task, &phone_handle);
+                errno_t rc = phone_alloc(task, &phone_handle);
                 if (rc != EOK) {
                         task->as = NULL;
@@ -345 +345 @@
  *
  */
-sysarg_t sys_task_get_id(sysarg64_t *uspace_taskid)
+sys_errno_t sys_task_get_id(sysarg64_t *uspace_taskid)
 {
         /*
@@ -351 +351 @@
          * the lifespan of the task.
          */
-        return (sysarg_t) copy_to_uspace(uspace_taskid, &TASK->taskid,
+        return (sys_errno_t) copy_to_uspace(uspace_taskid, &TASK->taskid,
             sizeof(TASK->taskid));
 }
@@ -385 +385 @@
  *
  */
-sysarg_t sys_task_set_name(const char *uspace_name, size_t name_len)
+sys_errno_t sys_task_set_name(const char *uspace_name, size_t name_len)
 {
         char namebuf[TASK_NAME_BUFLEN];
@@ -393 +393 @@
                 name_len = TASK_NAME_BUFLEN - 1;
         
-        int rc = copy_from_uspace(namebuf, uspace_name, name_len);
+        errno_t rc = copy_from_uspace(namebuf, uspace_name, name_len);
         if (rc != 0)
-                return (sysarg_t) rc;
+                return (sys_errno_t) rc;
         
         namebuf[name_len] = '\0';
@@ -426 +426 @@
  *
  */
-sysarg_t sys_task_kill(task_id_t *uspace_taskid)
+sys_errno_t sys_task_kill(task_id_t *uspace_taskid)
 {
         task_id_t taskid;
-        int rc = copy_from_uspace(&taskid, uspace_taskid, sizeof(taskid));
+        errno_t rc = copy_from_uspace(&taskid, uspace_taskid, sizeof(taskid));
         if (rc != 0)
-                return (sysarg_t) rc;
-        
-        return (sysarg_t) task_kill(taskid);
+                return (sys_errno_t) rc;
+        
+        return (sys_errno_t) task_kill(taskid);
 }
 
@@ -539 +539 @@
  *
  */
-int task_kill(task_id_t id)
+errno_t task_kill(task_id_t id)
 {
         if (id == 1)
@@ -596 +596 @@
  *
  */
-sysarg_t sys_task_exit(sysarg_t notify)
+sys_errno_t sys_task_exit(sysarg_t notify)
 {
         task_kill_self(notify);