Changeset b7fd2a0 in mainline for kernel/generic/src/mm/page.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/mm/page.c (modified) (2 diffs)

kernel/generic/src/mm/page.c

@@ -190 +190 @@
 }
 
-int page_find_mapping(uintptr_t virt, uintptr_t *phys)
+errno_t page_find_mapping(uintptr_t virt, uintptr_t *phys)
 {
         page_table_lock(AS, true);
@@ -215 +215 @@
  *
  */
-sysarg_t sys_page_find_mapping(uintptr_t virt, uintptr_t *phys_ptr)
+sys_errno_t sys_page_find_mapping(uintptr_t virt, uintptr_t *phys_ptr)
 {
         uintptr_t phys;
-        int rc = page_find_mapping(virt, &phys);
+        errno_t rc = page_find_mapping(virt, &phys);
         if (rc != EOK)
                 return rc;
         
         rc = copy_to_uspace(phys_ptr, &phys, sizeof(phys));
-        return (sysarg_t) rc;
+        return (sys_errno_t) rc;
 }