Changeset b7fd2a0 in mainline for kernel/generic/src/ipc/event.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/ipc/event.c (modified) (8 diffs)

kernel/generic/src/ipc/event.c

@@ -138 +138 @@
 }
 
-static int event_enqueue(event_t *event, bool mask, sysarg_t a1, sysarg_t a2,
+static errno_t event_enqueue(event_t *event, bool mask, sysarg_t a1, sysarg_t a2,
     sysarg_t a3, sysarg_t a4, sysarg_t a5)
 {
-        int res;
+        errno_t res;
 
         spinlock_lock(&event->lock);
@@ -206 +206 @@
  *
  */
-int event_notify(event_type_t evno, bool mask, sysarg_t a1, sysarg_t a2,
+errno_t event_notify(event_type_t evno, bool mask, sysarg_t a1, sysarg_t a2,
     sysarg_t a3, sysarg_t a4, sysarg_t a5)
 {
@@ -234 +234 @@
  *
  */
-int event_task_notify(task_t *task, event_task_type_t evno, bool mask,
+errno_t event_task_notify(task_t *task, event_task_type_t evno, bool mask,
     sysarg_t a1, sysarg_t a2, sysarg_t a3, sysarg_t a4, sysarg_t a5)
 {
@@ -255 +255 @@
  *
  */
-static int event_subscribe(event_t *event, sysarg_t imethod,
+static errno_t event_subscribe(event_t *event, sysarg_t imethod,
     answerbox_t *answerbox)
 {
-        int res;
+        errno_t res;
         
         spinlock_lock(&event->lock);
@@ -286 +286 @@
  *
  */
-static int event_unsubscribe(event_t *event, answerbox_t *answerbox)
-{
-        int res;
+static errno_t event_unsubscribe(event_t *event, answerbox_t *answerbox)
+{
+        errno_t res;
         
         spinlock_lock(&event->lock);
@@ -338 +338 @@
  *
  */
-sysarg_t sys_ipc_event_subscribe(sysarg_t evno, sysarg_t imethod)
+sys_errno_t sys_ipc_event_subscribe(sysarg_t evno, sysarg_t imethod)
 {
         if (evno >= EVENT_TASK_END)
                 return ELIMIT;
         
-        return (sysarg_t) event_subscribe(evno2event(evno, TASK),
+        return (sys_errno_t) event_subscribe(evno2event(evno, TASK),
             (sysarg_t) imethod, &TASK->answerbox);
 }
@@ -357 +357 @@
  *
  */
-sysarg_t sys_ipc_event_unsubscribe(sysarg_t evno)
+sys_errno_t sys_ipc_event_unsubscribe(sysarg_t evno)
 {
         if (evno >= EVENT_TASK_END)
                 return ELIMIT;
         
-        return (sysarg_t) event_unsubscribe(evno2event(evno, TASK),
+        return (sys_errno_t) event_unsubscribe(evno2event(evno, TASK),
             &TASK->answerbox);
 }
@@ -379 +379 @@
  *
  */
-sysarg_t sys_ipc_event_unmask(sysarg_t evno)
+sys_errno_t sys_ipc_event_unmask(sysarg_t evno)
 {
         if (evno >= EVENT_TASK_END)