Changeset add04f7 in mainline for kernel/arch/ia32/include/cpuid.h

Timestamp:

2009-03-03T15:20:49Z (16 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f24d300

Parents:

deca67b

Message:

better inline assembler readability using the new symbolic syntax

File:

• kernel/arch/ia32/include/cpuid.h (modified) (2 diffs)

kernel/arch/ia32/include/cpuid.h

@@ -75 +75 @@
         
         asm volatile (
-                "pushf\n"               /* read flags */
-                "popl %0\n"
-                "movl %0, %1\n"
+                "pushf\n"                    /* read flags */
+                "popl %[ret]\n"
+                "movl %[ret], %[val]\n"
                 
-                "btcl $21, %1\n"        /* swap the ID bit */
+                "btcl $21, %[val]\n"         /* swap the ID bit */
                 
-                "pushl %1\n"            /* propagate the change into flags */
+                "pushl %[val]\n"             /* propagate the change into flags */
                 "popf\n"
                 "pushf\n"
-                "popl %1\n"
+                "popl %[val]\n"
                 
-                "andl $(1 << 21), %0\n" /* interrested only in ID bit */
-                "andl $(1 << 21), %1\n"
-                "xorl %1, %0\n"
-                : "=r" (ret), "=r" (val)
+                "andl $(1 << 21), %[ret]\n"  /* interrested only in ID bit */
+                "andl $(1 << 21), %[val]\n"
+                "xorl %[val], %[ret]\n"
+                : [ret] "=r" (ret), [val] "=r" (val)
         );
         
@@ -99 +99 @@
         asm volatile (
                 "cpuid\n"
-                : "=a" (info->cpuid_eax), "=b" (info->cpuid_ebx), "=c" (info->cpuid_ecx), "=d" (info->cpuid_edx)
+                : "=a" (info->cpuid_eax), "=b" (info->cpuid_ebx),
+                  "=c" (info->cpuid_ecx), "=d" (info->cpuid_edx)
                 : "a" (cmd)
         );