Changeset a46e56b in mainline for uspace/srv/ns/task.c

Timestamp:

2018-03-22T06:49:35Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77f0a1d

Parents:

3e242d2

git-author:

Jakub Jermar <jakub@…> (2018-03-21 23:29:06)

git-committer:

Jakub Jermar <jakub@…> (2018-03-22 06:49:35)

Message:

Prefer handle over ID in naming handle variables

File:

• uspace/srv/ns/task.c (modified) (7 diffs)

uspace/srv/ns/task.c

@@ -146 +146 @@
         link_t link;
         task_id_t id;         /**< Task ID. */
-        cap_call_handle_t callid;  /**< Call ID waiting for the connection */
+        cap_call_handle_t chandle;  /**< Call ID waiting for the connection */
 } pending_wait_t;
 
@@ -184 +184 @@
                 texit = ht->have_rval ? TASK_EXIT_NORMAL :
                     TASK_EXIT_UNEXPECTED;
-                async_answer_2(pr->callid, EOK, texit, ht->retval);
+                async_answer_2(pr->chandle, EOK, texit, ht->retval);
 
                 list_remove(&pr->link);
@@ -192 +192 @@
 }
 
-void wait_for_task(task_id_t id, ipc_call_t *call, cap_call_handle_t callid)
+void wait_for_task(task_id_t id, ipc_call_t *call, cap_call_handle_t chandle)
 {
         ht_link_t *link = hash_table_find(&task_hash_table, &id);
@@ -200 +200 @@
         if (ht == NULL) {
                 /* No such task exists. */
-                async_answer_0(callid, ENOENT);
+                async_answer_0(chandle, ENOENT);
                 return;
         }
@@ -207 +207 @@
                 task_exit_t texit = ht->have_rval ? TASK_EXIT_NORMAL :
                     TASK_EXIT_UNEXPECTED;
-                async_answer_2(callid, EOK, texit, ht->retval);
+                async_answer_2(chandle, EOK, texit, ht->retval);
                 return;
         }
@@ -215 +215 @@
             (pending_wait_t *) malloc(sizeof(pending_wait_t));
         if (!pr) {
-                async_answer_0(callid, ENOMEM);
+                async_answer_0(chandle, ENOMEM);
                 return;
         }
@@ -221 +221 @@
         link_initialize(&pr->link);
         pr->id = id;
-        pr->callid = callid;
+        pr->chandle = chandle;
         list_append(&pr->link, &pending_wait);
 }