Changeset a35b458 in mainline for uspace/srv/devman/loc.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/srv/devman/loc.c

    r3061bc1 ra35b458  
    4343        char *loc_pathname = NULL;
    4444        char *loc_name = NULL;
    45        
     45
    4646        assert(fibril_rwlock_is_locked(&tree->rwlock));
    47        
     47
    4848        asprintf(&loc_name, "%s", fun->pathname);
    4949        if (loc_name == NULL)
    5050                return;
    51        
     51
    5252        replace_char(loc_name, '/', LOC_SEPARATOR);
    53        
     53
    5454        asprintf(&loc_pathname, "%s/%s", LOC_DEVICE_NAMESPACE,
    5555            loc_name);
     
    5858                return;
    5959        }
    60        
     60
    6161        loc_service_register(loc_pathname, &fun->service_id);
    62        
     62
    6363        tree_add_loc_function(tree, fun);
    64        
     64
    6565        free(loc_name);
    6666        free(loc_pathname);
     
    7777{
    7878        fun_node_t *fun = NULL;
    79        
     79
    8080        fibril_rwlock_read_lock(&tree->rwlock);
    8181        ht_link_t *link = hash_table_find(&tree->loc_functions, &service_id);
     
    8585        }
    8686        fibril_rwlock_read_unlock(&tree->rwlock);
    87        
     87
    8888        return fun;
    8989}
     
    9292{
    9393        assert(fibril_rwlock_is_write_locked(&tree->rwlock));
    94        
     94
    9595        hash_table_insert(&tree->loc_functions, &fun->loc_fun);
    9696}
     
    9999{
    100100        assert(fibril_rwlock_is_write_locked(&tree->rwlock));
    101        
     101
    102102        hash_table_remove(&tree->loc_functions, &fun->service_id);
    103103}
Note: See TracChangeset for help on using the changeset viewer.