Changeset a35b458 in mainline for uspace/lib/http/src/request.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • uspace/lib/http/src/request.c

    r3061bc1 ra35b458  
    5252        if (req == NULL)
    5353                return NULL;
    54        
     54
    5555        req->method = str_dup(method);
    5656        if (req->method == NULL) {
    … …  
    5858                return NULL;
    5959        }
    60        
     60
    6161        req->path = str_dup(path);
    6262        if (req->path == NULL) {
    … …  
    6565                return NULL;
    6666        }
    67        
     67
    6868        http_headers_init(&req->headers);
    69        
     69
    7070        return req;
    7171}
    … …  
    9898                return EINVAL;
    9999        size_t size = meth_size;
    100        
     100
    101101        http_headers_foreach(req->headers, header) {
    102102                ssize_t header_size = http_header_encode(header, NULL, 0);
    … …  
    106106        }
    107107        size += str_length(HTTP_REQUEST_LINE);
    108        
     108
    109109        char *buf = malloc(size);
    110110        if (buf == NULL)
    111111                return ENOMEM;
    112        
     112
    113113        char *pos = buf;
    114114        size_t pos_size = size;
    … …  
    120120        pos += written;
    121121        pos_size -= written;
    122        
     122
    123123        http_headers_foreach(req->headers, header) {
    124124                written = http_header_encode(header, pos, pos_size);
    … …  
    130130                pos_size -= written;
    131131        }
    132        
     132
    133133        size_t rlsize = str_size(HTTP_REQUEST_LINE);
    134134        memcpy(pos, HTTP_REQUEST_LINE, rlsize);
    135135        pos_size -= rlsize;
    136136        assert(pos_size == 0);
    137        
     137
    138138        *out_buf = buf;
    139139        *out_buf_size = size;
    … …  
    145145        char *buf = NULL;
    146146        size_t buf_size = 0;
    147        
     147
    148148        errno_t rc = http_request_format(req, &buf, &buf_size);
    149149        if (rc != EOK)
    150150                return rc;
    151        
     151
    152152        rc = tcp_conn_send(http->conn, buf, buf_size);
    153153        free(buf);
    154        
     154
    155155        return rc;
    156156}
Note: See TracChangeset for help on using the changeset viewer.