Changeset a35b458 in mainline for uspace/lib/c/generic/elf/elf_mod.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/c/generic/elf/elf_mod.c

    r3061bc1 ra35b458  
    166166                return EE_INVALID;
    167167        }
    168        
     168
    169169        /* Identify ELF compatibility */
    170170        if (header->e_ident[EI_DATA] != ELF_DATA_ENCODING ||
     
    372372                flags |= AS_AREA_READ;
    373373        flags |= AS_AREA_CACHEABLE;
    374        
     374
    375375        base = ALIGN_DOWN(entry->p_vaddr, PAGE_SIZE);
    376376        mem_sz = entry->p_memsz + (entry->p_vaddr - base);
     
    458458                break;
    459459        }
    460        
     460
    461461        return EE_OK;
    462462}
Note: See TracChangeset for help on using the changeset viewer.