Changeset a35b458 in mainline for uspace/drv/platform/mac/mac.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/drv/platform/mac/mac.c

    r3061bc1 ra35b458  
    130130        ddf_msg(LVL_DEBUG, "Adding new function '%s'.", name);
    131131        printf("mac: Adding new function '%s'.\n", name);
    132        
     132
    133133        ddf_fun_t *fnode = NULL;
    134134        errno_t rc;
    135        
     135
    136136        /* Create new device. */
    137137        fnode = ddf_fun_create(dev, fun_inner, name);
    138138        if (fnode == NULL)
    139139                goto failure;
    140        
     140
    141141        mac_fun_t *fun = ddf_fun_data_alloc(fnode, sizeof(mac_fun_t));
    142142        *fun = *fun_proto;
    143        
     143
    144144        /* Add match ID */
    145145        rc = ddf_fun_add_match_id(fnode, str_match_id, 100);
    146146        if (rc != EOK)
    147147                goto failure;
    148        
     148
    149149        /* Set provided operations to the device. */
    150150        ddf_fun_set_ops(fnode, &mac_fun_ops);
    151        
     151
    152152        /* Register function. */
    153153        if (ddf_fun_bind(fnode) != EOK) {
     
    155155                goto failure;
    156156        }
    157        
     157
    158158        printf("mac: Added new function '%s' (str=%s).\n", name, str_match_id);
    159159        return true;
    160        
     160
    161161failure:
    162162        if (fnode != NULL)
    163163                ddf_fun_destroy(fnode);
    164        
     164
    165165        ddf_msg(LVL_ERROR, "Failed adding function '%s'.", name);
    166        
     166
    167167        return false;
    168168}
     
    223223        mac_fun_t *fun = mac_fun(fnode);
    224224        assert(fun != NULL);
    225        
     225
    226226        return &fun->hw_resources;
    227227}
     
    230230{
    231231        /* TODO */
    232        
     232
    233233        return false;
    234234}
Note: See TracChangeset for help on using the changeset viewer.