Changeset a35b458 in mainline for tools/dest_build.py

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• tools/dest_build.py (modified) (4 diffs)

tools/dest_build.py

@@ -42 +42 @@
 def duplicate_tree(src_path, dest_path, current):
         "Duplicate source directory tree in the destination path"
-        
+
         for name in os.listdir(os.path.join(src_path, current)):
                 if name in exclude_names:
                         next
-                
+
                 following = os.path.join(current, name)
                 src = os.path.join(src_path, following)
@@ -52 +52 @@
                 dest_parent = os.path.join(dest_path, current)
                 dest_stat = os.stat(src)
-                
+
                 # Create shadow directories
                 if stat.S_ISDIR(dest_stat.st_mode):
                         if not os.path.exists(dest):
                                 os.mkdir(dest)
-                        
+
                         if not os.path.isdir(dest):
                                 raise IOError(errno.ENOTDIR, "Destination path exists, but is not a directory", dest)
-                        
+
                         duplicate_tree(src_path, dest_path, following)
                 else:
                         # Compute the relative path from destination to source
                         relative = os.path.relpath(src, dest_parent)
-                        
+
                         # Create symlink
                         if not os.path.exists(dest):
@@ -78 +78 @@
                 usage(sys.argv[0])
                 return 1
-        
+
         # Source tree path
         src_path = os.path.abspath(sys.argv[1])
@@ -84 +84 @@
                 print("<SRC_PATH> must be a directory")
                 return 2
-        
+
         # Destination tree path
         dest_path = os.path.abspath(sys.argv[2])
         if not os.path.exists(dest_path):
                 os.mkdir(dest_path)
-        
+
         if not os.path.isdir(dest_path):
                 print("<DEST_PATH> must be a directory")
                 return 3
-        
+
         # Duplicate source directory tree
         duplicate_tree(src_path, dest_path, "")
-        
+
         # Run the build from the destination tree
         os.chdir(dest_path)
         args = ["make"]
         args.extend(sys.argv[3:])
-        
+
         return subprocess.Popen(args).wait()