Changeset a35b458 in mainline for tools/checkers/clang.py

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• tools/checkers/clang.py (modified) (5 diffs)

tools/checkers/clang.py

@@ -46 +46 @@
 def clang(root, job):
         "Run Clang on a jobfile"
-        
+
         inname = os.path.join(root, job)
-        
+
         if (not os.path.isfile(inname)):
                 print("Unable to open %s" % inname)
                 print("Did you run \"make precheck\" on the source tree?")
                 return False
-        
+
         inf = open(inname, "r")
         records = inf.read().splitlines()
         inf.close()
-        
+
         for record in records:
                 arg = jobfile.parse_arg(record)
                 if (not arg):
                         return False
-                
+
                 if (len(arg) < 6):
                         print("Not enough jobfile record arguments")
                         return False
-                
+
                 srcfname = arg[0]
                 tgtfname = arg[1]
@@ -73 +73 @@
                 base = arg[4]
                 options = arg[5].split()
-                
+
                 srcfqname = os.path.join(base, srcfname)
                 if (not os.path.isfile(srcfqname)):
                         print("Source %s not found" % srcfqname)
                         return False
-                
+
                 # Only C files are interesting for us
                 if (tool != "cc"):
                         continue
-                
+
                 args = ['clang', '-Qunused-arguments', '--analyze',
                         '-Xanalyzer', '-analyzer-opt-analyze-headers',
@@ -88 +88 @@
                 args.extend(options)
                 args.extend(['-o', tgtfname, srcfname])
-                
+
                 cwd = os.getcwd()
                 os.chdir(base)
                 retval = subprocess.Popen(args).wait()
                 os.chdir(cwd)
-                
+
                 if (retval != 0):
                         return False
-                
+
         return True
 
@@ -103 +103 @@
                 usage(sys.argv[0])
                 return
-        
+
         rootdir = os.path.abspath(sys.argv[1])
         config = os.path.join(rootdir, "HelenOS.config")
-        
+
         if (not os.path.isfile(config)):
                 print("%s not found." % config)
                 print("Please specify the path to HelenOS build tree root as the first argument.")
                 return
-        
+
         for job in jobs:
                 if (not clang(rootdir, job)):
@@ -117 +117 @@
                         print("Failed job: %s" % job)
                         return
-        
+
         print
         print("All jobs passed")