Changeset a35b458 in mainline for kernel/generic/src/syscall/copy.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • kernel/generic/src/syscall/copy.c

    r3061bc1 ra35b458  
    2626 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2727 */
    28    
     28
    2929/** @addtogroup generic
    3030 * @{
     
    6363        ipl_t ipl;
    6464        errno_t rc;
    65        
     65
    6666        assert(THREAD);
    6767        assert(!THREAD->in_copy_from_uspace);
    68        
     68
    6969        if (!KERNEL_ADDRESS_SPACE_SHADOWED) {
    7070                if (overlaps((uintptr_t) uspace_src, size,
     
    8686                return EPERM;
    8787#endif
    88        
     88
    8989        ipl = interrupts_disable();
    9090        THREAD->in_copy_from_uspace = true;
    91        
     91
    9292        rc = memcpy_from_uspace(dst, uspace_src, size);
    9393
     
    114114        ipl_t ipl;
    115115        errno_t rc;
    116        
     116
    117117        assert(THREAD);
    118118        assert(!THREAD->in_copy_to_uspace);
    119        
     119
    120120        if (!KERNEL_ADDRESS_SPACE_SHADOWED) {
    121121                if (overlaps((uintptr_t) uspace_dst, size,
     
    137137                return EPERM;
    138138#endif
    139        
     139
    140140        ipl = interrupts_disable();
    141141        THREAD->in_copy_to_uspace = true;
    142        
     142
    143143        rc = memcpy_to_uspace(uspace_dst, src, size);
    144144
Note: See TracChangeset for help on using the changeset viewer.