Changeset 9efad54 in mainline for uspace/lib/usbdev/src/devdrv.c

Timestamp:

2018-01-06T21:15:48Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

56257ba

Parents:

c901632

Message:

usb: move endpoint descriptor parsing to HC

This better separates responsibilities. Now the device driver does not
care about the contents of an endpoint descriptor, and HC can parse the
values according to device's actual speed.

Currently, it is device driver's responsibility to fetch endpoint
descriptors, map them and register pipes - sending the endpoint
descriptor back to HC. HC then parses it, and fills the pipe
description, which then sends back to device driver. We shall probably
fetch the endpoint descriptor from inside the HC (also fixing the USB
spec violation of communication with EP0).

File:

• uspace/lib/usbdev/src/devdrv.c (modified) (3 diffs)

uspace/lib/usbdev/src/devdrv.c

@@ -255 +255 @@
 
         /* Register created pipes. */
+        unsigned pipes_registered = 0;
         for (size_t i = 0; i < pipe_count; i++) {
                 if (pipes[i].present) {
-                        rc = usb_pipe_register(&pipes[i].pipe);
+                        rc = usb_pipe_register(&pipes[i].pipe, pipes[i].descriptor, pipes[i].companion_descriptor);
                         if (rc != EOK) {
                                 goto rollback_unregister_endpoints;
                         }
                 }
+                pipes_registered++;
         }
 
@@ -276 +278 @@
          */
 rollback_unregister_endpoints:
-        for (size_t i = 0; i < pipe_count; i++) {
+        for (size_t i = 0; i < pipes_registered; i++) {
                 if (pipes[i].present) {
                         usb_pipe_unregister(&pipes[i].pipe);
@@ -419 +421 @@
         /* This pipe was registered by the hub driver,
          * during device initialization. */
-        int rc = usb_pipe_initialize_default_control(
-            &usb_dev->ctrl_pipe, usb_dev->bus_session);
+        int rc = usb_pipe_initialize_default_control(&usb_dev->ctrl_pipe, usb_dev->bus_session);
         if (rc != EOK) {
                 usb_dev_disconnect(usb_dev->bus_session);