Changeset 9d5e23c in mainline for tools/config.py

Timestamp:

2005-12-07T23:52:25Z (20 years ago)

Author:

Ondrej Palkovsky <ondrap@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ac0cb2a

Parents:

f62355a

Message:

Fixed bug in Intel32/AMD64 boot, that could cause page fault on boot.
Fixes of configuration program.

File:

• tools/config.py (modified) (4 diffs)

tools/config.py

@@ -266 +266 @@
 def parse_config(input, output, dlg, defaults={}, askonly=None):
     "Parse configuration file and create Makefile.config on the fly"
-    def ask_the_question():
+    def ask_the_question(dialog):
         "Ask question based on the type of variables to ask"
         # This is quite a hack, this thingy is written just to
         # have access to local variables..
         if vartype == 'y/n':
-            return dlg.yesno(comment, default)
+            return dialog.yesno(comment, default)
         elif vartype == 'n/y':
-            return dlg.noyes(comment, default)
+            return dialog.noyes(comment, default)
         elif vartype == 'choice':
             defopt = None
@@ -281 +281 @@
                         defopt = i
                         break
-            return dlg.choice(comment, choices, defopt)
+            return dialog.choice(comment, choices, defopt)
         else:
             raise RuntimeError("Bad method: %s" % vartype)
@@ -317 +317 @@
                     if arg.startswith('$'):
                         args[i] = defaults[arg[1:]]
-
-                subc = os.popen(' '.join(args),'r')
-                data = subc.read().strip()
-                if subc.close():
+                data,status = commands.getstatusoutput(' '.join(args))
+                if status:
                     raise RuntimeError('Error running: %s' % ' '.join(args))
-                outf.write('%s = %s\n' % (varname,data))
+                outf.write('%s = %s\n' % (varname,data.strip()))
             continue
             
@@ -348 +346 @@
 
             if default is None or not askonly or askonly == varname:
-                default = ask_the_question()
+                default = ask_the_question(dlg)
+            else:
+                default = ask_the_question(DefaultDialog(dlg))
 
             outf.write('%s = %s\n' % (varname, default))