Changeset 8b420fa in mainline for kernel/arch/sparc64/src/proc/thread.c

Timestamp:

2016-06-08T21:41:43Z (9 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

741b2fb1

Parents:

7510326

Message:

Make explicitly sure the userspace window buffer is properly aligned

Do not rely on the implementation of kernel malloc() to assure this.
Instead, create a dedicated slab cache with the proper alignment for
its objects and allocate UWB's from there.

File:

• kernel/arch/sparc64/src/proc/thread.c (modified) (4 diffs)

kernel/arch/sparc64/src/proc/thread.c

@@ -39 +39 @@
 #include <align.h>
 
+slab_cache_t *uwb_cache = NULL;
+
 void thr_constructor_arch(thread_t *t)
 {
@@ -55 +57 @@
                  * belonging to a killed thread.
                  */
-                free((uint8_t *) ALIGN_DOWN(uw_buf, UWB_ALIGNMENT));
+                slab_free(uwb_cache, (uint8_t *) ALIGN_DOWN(uw_buf,
+                    UWB_ALIGNMENT));
         }
 }
@@ -67 +70 @@
                  * returned from the slab allocator doesn't have any.
                  */
-                t->arch.uspace_window_buffer = malloc(UWB_ASIZE, 0);
+                t->arch.uspace_window_buffer = slab_alloc(uwb_cache, 0);
         } else {
                 uintptr_t uw_buf = (uintptr_t) t->arch.uspace_window_buffer;
@@ -76 +79 @@
                  */
                 t->arch.uspace_window_buffer = (uint8_t *) ALIGN_DOWN(uw_buf,
-                    UWB_ASIZE);
+                    UWB_ALIGNMENT);
         }
 }