Changeset 8b243f2 in mainline for uspace/rd/rd.c

Timestamp:

2007-06-17T19:34:36Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

bd72c3e9

Parents:

4680ef5

Message:

Greatly improve comments in the IPC layer.
Now I think I finally start to understand our IPC internals

File:

• uspace/rd/rd.c (modified) (3 diffs)

uspace/rd/rd.c

@@ -67 +67 @@
                 callid = async_get_call(&call);
                 switch (IPC_GET_METHOD(call)) {
-                        case IPC_M_PHONE_HUNGUP:
-                                ipc_answer_fast(callid, 0,0,0);
-                                return;
-                        case IPC_M_AS_AREA_SEND:
-                                ipc_answer_fast(callid, 0, (uintptr_t)fs_addr, 0);
-                                continue;
-                        case RD_READ_BLOCK:                     
-                                offset = IPC_GET_ARG1(call);
-                                memcpy((void *)fs_addr, rd_addr+offset, BLOCK_SIZE);
-                                retval = EOK;
-                                break;
-                        default:
-                                retval = EINVAL;
+                case IPC_M_PHONE_HUNGUP:
+                        ipc_answer_fast(callid, 0, 0, 0);
+                        return;
+                case IPC_M_AS_AREA_SEND:
+                        ipc_answer_fast(callid, 0, (uintptr_t) fs_addr, 0);
+                        continue;
+                case RD_READ_BLOCK:                     
+                        offset = IPC_GET_ARG1(call);
+                        memcpy((void *) fs_addr, rd_addr + offset, BLOCK_SIZE);
+                        retval = EOK;
+                        break;
+                default:
+                        retval = EINVAL;
                 }
                 ipc_answer_fast(callid, retval, 0, 0);
-        }       
+        }
 }
 
@@ -91 +91 @@
 
         size_t rd_size = sysinfo_value("rd.size");
-        void * rd_ph_addr = (void *) sysinfo_value("rd.address.physical");
+        void *rd_ph_addr = (void *) sysinfo_value("rd.address.physical");
         
         if (rd_size == 0)
@@ -99 +99 @@
         
         flags = AS_AREA_READ | AS_AREA_WRITE | AS_AREA_CACHEABLE;
-        retval = physmem_map(rd_ph_addr, rd_addr, ALIGN_UP(rd_size, PAGE_SIZE) >> PAGE_WIDTH, flags);
+        retval = physmem_map(rd_ph_addr, rd_addr,
+            ALIGN_UP(rd_size, PAGE_SIZE) >> PAGE_WIDTH, flags);
 
         if (retval < 0)