Changeset 831aa466 in mainline for uspace/lib/drv/generic/remote_usb.c

Timestamp:

2018-06-26T23:16:12Z (7 years ago)

Author:

Jiří Zárevúcky <jiri.zarevucky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2fc9bfd

Parents:

70fae4e

git-author:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-06-26 23:06:11)

git-committer:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-06-26 23:16:12)

Message:

Fix cases of undefined behavior found by ubsan.

File:

• uspace/lib/drv/generic/remote_usb.c (modified) (1 diff)

uspace/lib/drv/generic/remote_usb.c

@@ -77 +77 @@
                 return EBADMEM;
 
-        usb_device_desc_t tmp_desc;
+        sysarg_t address, depth, speed, handle, iface;
 
         const errno_t ret = async_req_1_5(exch, DEV_IFACE_ID(USB_DEV_IFACE),
-            IPC_M_USB_GET_MY_DESCRIPTION,
-            (sysarg_t *) &tmp_desc.address,
-            (sysarg_t *) &tmp_desc.depth,
-            (sysarg_t *) &tmp_desc.speed,
-            &tmp_desc.handle,
-            (sysarg_t *) &tmp_desc.iface);
-        if (ret == EOK && desc)
-                *desc = tmp_desc;
+            IPC_M_USB_GET_MY_DESCRIPTION, &address, &depth, &speed, &handle,
+            &iface);
+        if (ret == EOK && desc) {
+                *desc = (usb_device_desc_t) {
+                        .address = address,
+                        .depth = depth,
+                        .speed = speed,
+                        .handle = handle,
+                        .iface = iface,
+                };
+        }
+
         return ret;
 }