Changeset 7e752b2 in mainline for kernel/arch/amd64

Timestamp:

2010-11-26T01:33:20Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

bf61d3a

Parents:

202f57b

Message:

• correct printf() formatting strings and corresponding arguments
• minor cstyle changes and other small fixes

Location:

kernel/arch/amd64/src

Files:

• debugger.c (modified) (3 diffs)
• interrupt.c (modified) (1 diff)
• mm/page.c (modified) (2 diffs)

kernel/arch/amd64/src/debugger.c

@@ -230 +230 @@
                                 return;
                         
-                        printf("*** Found ZERO on address %" PRIp " (slot %d) ***\n",
-                            breakpoints[slot].address, slot);
+                        printf("*** Found ZERO on address %p (slot %d) ***\n",
+                            (void *) breakpoints[slot].address, slot);
                 } else {
-                        printf("Data watchpoint - new data: %" PRIp "\n",
+                        printf("Data watchpoint - new data: %#" PRIxn "\n",
                             *((unative_t *) breakpoints[slot].address));
                 }
         }
         
-        printf("Reached breakpoint %d:%" PRIp " (%s)\n", slot, getip(istate),
-            symtab_fmt_name_lookup(getip(istate)));
+        printf("Reached breakpoint %d:%p (%s)\n", slot,
+            (void *) getip(istate), symtab_fmt_name_lookup(getip(istate)));
         
 #ifdef CONFIG_KCONSOLE
@@ -363 +363 @@
                         
 #ifdef __32_BITS__
-                        printf("%-4u %7" PRIs " %p %s\n", i,
-                            breakpoints[i].counter, breakpoints[i].address,
+                        printf("%-4u %7zu %p %s\n", i,
+                            breakpoints[i].counter, (void *) breakpoints[i].address,
                             symbol);
 #endif
                         
 #ifdef __64_BITS__
-                        printf("%-4u %7" PRIs " %p %s\n", i,
-                            breakpoints[i].counter, breakpoints[i].address,
+                        printf("%-4u %7zu %p %s\n", i,
+                            breakpoints[i].counter, (void *) breakpoints[i].address,
                             symbol);
 #endif
@@ -405 +405 @@
                 flags = BKPOINT_WRITE;
         
-        printf("Adding breakpoint on address: %p\n", argv->intval);
-        
-        int id = breakpoint_add((void *)argv->intval, flags, -1);
+        printf("Adding breakpoint on address: %p\n",
+            (void *) argv->intval);
+        
+        int id = breakpoint_add((void *) argv->intval, flags, -1);
         if (id < 0)
                 printf("Add breakpoint failed.\n");

kernel/arch/amd64/src/interrupt.c

@@ -65 +65 @@
 void istate_decode(istate_t *istate)
 {
-        printf("cs =%p\trip=%p\trfl=%p\terr=%p\n",
-            istate->cs, istate->rip, istate->rflags, istate->error_word);
-
+        printf("cs =%#0" PRIx64 "\trip=%p\t"
+            "rfl=%#0" PRIx64 "\terr=%#0" PRIx64 "\n",
+            istate->cs, (void *) istate->rip,
+            istate->rflags, istate->error_word);
+        
         if (istate_from_uspace(istate))
-                printf("ss =%p\n", istate->ss);
-        
-        printf("rax=%p\trbx=%p\trcx=%p\trdx=%p\n",
+                printf("ss =%#0" PRIx64 "\n", istate->ss);
+        
+        printf("rax=%#0" PRIx64 "\trbx=%#0" PRIx64 "\t"
+            "rcx=%#0" PRIx64 "\trdx=%#0" PRIx64 "\n",
             istate->rax, istate->rbx, istate->rcx, istate->rdx);
+        
         printf("rsi=%p\trdi=%p\trbp=%p\trsp=%p\n",
-            istate->rsi, istate->rdi, istate->rbp,
-            istate_from_uspace(istate) ? istate->rsp : (uintptr_t)&istate->rsp);
-        printf("r8 =%p\tr9 =%p\tr10=%p\tr11=%p\n",
+            (void *) istate->rsi, (void *) istate->rdi,
+            (void *) istate->rbp,
+            istate_from_uspace(istate) ? ((void *) istate->rsp) :
+            &istate->rsp);
+        
+        printf("r8 =%#0" PRIx64 "\tr9 =%#0" PRIx64 "\t"
+            "r10=%#0" PRIx64 "\tr11=%#0" PRIx64 "\n",
             istate->r8, istate->r9, istate->r10, istate->r11);
-        printf("r12=%p\tr13=%p\tr14=%p\tr15=%p\n",
+        
+        printf("r12=%#0" PRIx64 "\tr13=%#0" PRIx64 "\t"
+            "r14=%#0" PRIx64 "\tr15=%#0" PRIx64 "\n",
             istate->r12, istate->r13, istate->r14, istate->r15);
 }

kernel/arch/amd64/src/mm/page.c

@@ -89 +89 @@
         
         if (as_page_fault(page, access, istate) == AS_PF_FAULT) {
-                fault_if_from_uspace(istate, "Page fault: %#x.", page);
+                fault_if_from_uspace(istate, "Page fault: %p.", (void *) page);
                 panic_memtrap(istate, access, page, NULL);
         }
@@ -97 +97 @@
 {
         if (last_frame + ALIGN_UP(size, PAGE_SIZE) > KA2PA(KERNEL_ADDRESS_SPACE_END_ARCH))
-                panic("Unable to map physical memory %p (%" PRIs " bytes).", physaddr,
-                    size);
+                panic("Unable to map physical memory %p (%zu bytes).",
+                    (void *) physaddr, size);
         
         uintptr_t virtaddr = PA2KA(last_frame);