Changeset 7bdcc45 in mainline for kernel/arch/amd64/src

Timestamp:

2010-12-16T16:38:49Z (15 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7837101

Parents:

8e58f94 (diff), eb221e5 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

Location:

kernel/arch/amd64/src

Files:

• amd64.c (modified) (1 diff)
• boot/memmap.c (modified) (1 diff)
• cpu/cpu.c (modified) (1 diff)
• debugger.c (modified) (9 diffs)
• interrupt.c (modified) (1 diff)
• mm/page.c (modified) (2 diffs)
• pm.c (modified) (7 diffs)

kernel/arch/amd64/src/amd64.c

@@ -256 +256 @@
  * we need not to go to CPL0 to read it.
  */
-unative_t sys_tls_set(unative_t addr)
+sysarg_t sys_tls_set(sysarg_t addr)
 {
         THREAD->arch.tls = addr;

kernel/arch/amd64/src/boot/memmap.c

@@ -35 +35 @@
 #include <arch/boot/memmap.h>
 
-uint8_t e820counter = 0xff;
+uint8_t e820counter = 0xffU;
 e820memmap_t e820table[MEMMAP_E820_MAX_RECORDS];
 

kernel/arch/amd64/src/cpu/cpu.c

@@ -47 +47 @@
  * Contains only non-MP-Specification specific SMP code.
  */
-#define AMD_CPUID_EBX  0x68747541
-#define AMD_CPUID_ECX  0x444d4163
-#define AMD_CPUID_EDX  0x69746e65
+#define AMD_CPUID_EBX  UINT32_C(0x68747541)
+#define AMD_CPUID_ECX  UINT32_C(0x444d4163)
+#define AMD_CPUID_EDX  UINT32_C(0x69746e65)
 
-#define INTEL_CPUID_EBX  0x756e6547
-#define INTEL_CPUID_ECX  0x6c65746e
-#define INTEL_CPUID_EDX  0x49656e69
-
+#define INTEL_CPUID_EBX  UINT32_C(0x756e6547)
+#define INTEL_CPUID_ECX  UINT32_C(0x6c65746e)
+#define INTEL_CPUID_EDX  UINT32_C(0x49656e69)
 
 enum vendor {

kernel/arch/amd64/src/debugger.c

@@ -125 +125 @@
         
         /* Disable breakpoint in DR7 */
-        unative_t dr7 = read_dr7();
-        dr7 &= ~(0x2 << (curidx * 2));
+        sysarg_t dr7 = read_dr7();
+        dr7 &= ~(0x02U << (curidx * 2));
         
         /* Setup DR register */
@@ -147 +147 @@
                 
                 /* Set type to requested breakpoint & length*/
-                dr7 &= ~(0x3 << (16 + 4 * curidx));
-                dr7 &= ~(0x3 << (18 + 4 * curidx));
+                dr7 &= ~(0x03U << (16 + 4 * curidx));
+                dr7 &= ~(0x03U << (18 + 4 * curidx));
                 
                 if (!(flags & BKPOINT_INSTR)) {
 #ifdef __32_BITS__
-                        dr7 |= ((unative_t) 0x3) << (18 + 4 * curidx);
+                        dr7 |= ((sysarg_t) 0x03U) << (18 + 4 * curidx);
 #endif
                         
 #ifdef __64_BITS__
-                        dr7 |= ((unative_t) 0x2) << (18 + 4 * curidx);
+                        dr7 |= ((sysarg_t) 0x02U) << (18 + 4 * curidx);
 #endif
                         
                         if ((flags & BKPOINT_WRITE))
-                                dr7 |= ((unative_t) 0x1) << (16 + 4 * curidx);
+                                dr7 |= ((sysarg_t) 0x01U) << (16 + 4 * curidx);
                         else if ((flags & BKPOINT_READ_WRITE))
-                                dr7 |= ((unative_t) 0x3) << (16 + 4 * curidx);
+                                dr7 |= ((sysarg_t) 0x03U) << (16 + 4 * curidx);
                 }
                 
                 /* Enable global breakpoint */
-                dr7 |= 0x2 << (curidx * 2);
+                dr7 |= 0x02U << (curidx * 2);
                 
                 write_dr7(dr7);
@@ -227 +227 @@
         if (!(breakpoints[slot].flags & BKPOINT_INSTR)) {
                 if ((breakpoints[slot].flags & BKPOINT_CHECK_ZERO)) {
-                        if (*((unative_t *) breakpoints[slot].address) != 0)
+                        if (*((sysarg_t *) breakpoints[slot].address) != 0)
                                 return;
                         
-                        printf("*** Found ZERO on address %" PRIp " (slot %d) ***\n",
-                            breakpoints[slot].address, slot);
+                        printf("*** Found ZERO on address %p (slot %d) ***\n",
+                            (void *) breakpoints[slot].address, slot);
                 } else {
-                        printf("Data watchpoint - new data: %" PRIp "\n",
-                            *((unative_t *) breakpoints[slot].address));
-                }
-        }
-        
-        printf("Reached breakpoint %d:%" PRIp " (%s)\n", slot, getip(istate),
-            symtab_fmt_name_lookup(getip(istate)));
+                        printf("Data watchpoint - new data: %#" PRIxn "\n",
+                            *((sysarg_t *) breakpoints[slot].address));
+                }
+        }
+        
+        printf("Reached breakpoint %d:%p (%s)\n", slot,
+            (void *) getip(istate), symtab_fmt_name_lookup(getip(istate)));
         
 #ifdef CONFIG_KCONSOLE
@@ -260 +260 @@
         }
         
-        cur->address = NULL;
+        cur->address = (uintptr_t) NULL;
         
         setup_dr(slot);
@@ -279 +279 @@
 #endif
         
-        unative_t dr6 = read_dr6();
+        sysarg_t dr6 = read_dr6();
         
         unsigned int i;
@@ -313 +313 @@
         unsigned int i;
         for (i = 0; i < BKPOINTS_MAX; i++)
-                breakpoints[i].address = NULL;
+                breakpoints[i].address = (uintptr_t) NULL;
         
 #ifdef CONFIG_KCONSOLE
@@ -363 +363 @@
                         
 #ifdef __32_BITS__
-                        printf("%-4u %7" PRIs " %p %s\n", i,
-                            breakpoints[i].counter, breakpoints[i].address,
+                        printf("%-4u %7zu %p %s\n", i,
+                            breakpoints[i].counter, (void *) breakpoints[i].address,
                             symbol);
 #endif
                         
 #ifdef __64_BITS__
-                        printf("%-4u %7" PRIs " %p %s\n", i,
-                            breakpoints[i].counter, breakpoints[i].address,
+                        printf("%-4u %7zu %p %s\n", i,
+                            breakpoints[i].counter, (void *) breakpoints[i].address,
                             symbol);
 #endif
@@ -384 +384 @@
 int cmd_del_breakpoint(cmd_arg_t *argv)
 {
-        unative_t bpno = argv->intval;
+        sysarg_t bpno = argv->intval;
         if (bpno > BKPOINTS_MAX) {
                 printf("Invalid breakpoint number.\n");
@@ -405 +405 @@
                 flags = BKPOINT_WRITE;
         
-        printf("Adding breakpoint on address: %p\n", argv->intval);
-        
-        int id = breakpoint_add((void *)argv->intval, flags, -1);
+        printf("Adding breakpoint on address: %p\n",
+            (void *) argv->intval);
+        
+        int id = breakpoint_add((void *) argv->intval, flags, -1);
         if (id < 0)
                 printf("Add breakpoint failed.\n");

kernel/arch/amd64/src/interrupt.c

@@ -65 +65 @@
 void istate_decode(istate_t *istate)
 {
-        printf("cs =%p\trip=%p\trfl=%p\terr=%p\n",
-            istate->cs, istate->rip, istate->rflags, istate->error_word);
-
+        printf("cs =%#0" PRIx64 "\trip=%p\t"
+            "rfl=%#0" PRIx64 "\terr=%#0" PRIx64 "\n",
+            istate->cs, (void *) istate->rip,
+            istate->rflags, istate->error_word);
+        
         if (istate_from_uspace(istate))
-                printf("ss =%p\n", istate->ss);
-        
-        printf("rax=%p\trbx=%p\trcx=%p\trdx=%p\n",
+                printf("ss =%#0" PRIx64 "\n", istate->ss);
+        
+        printf("rax=%#0" PRIx64 "\trbx=%#0" PRIx64 "\t"
+            "rcx=%#0" PRIx64 "\trdx=%#0" PRIx64 "\n",
             istate->rax, istate->rbx, istate->rcx, istate->rdx);
+        
         printf("rsi=%p\trdi=%p\trbp=%p\trsp=%p\n",
-            istate->rsi, istate->rdi, istate->rbp,
-            istate_from_uspace(istate) ? istate->rsp : (uintptr_t)&istate->rsp);
-        printf("r8 =%p\tr9 =%p\tr10=%p\tr11=%p\n",
+            (void *) istate->rsi, (void *) istate->rdi,
+            (void *) istate->rbp,
+            istate_from_uspace(istate) ? ((void *) istate->rsp) :
+            &istate->rsp);
+        
+        printf("r8 =%#0" PRIx64 "\tr9 =%#0" PRIx64 "\t"
+            "r10=%#0" PRIx64 "\tr11=%#0" PRIx64 "\n",
             istate->r8, istate->r9, istate->r10, istate->r11);
-        printf("r12=%p\tr13=%p\tr14=%p\tr15=%p\n",
+        
+        printf("r12=%#0" PRIx64 "\tr13=%#0" PRIx64 "\t"
+            "r14=%#0" PRIx64 "\tr15=%#0" PRIx64 "\n",
             istate->r12, istate->r13, istate->r14, istate->r15);
 }

kernel/arch/amd64/src/mm/page.c

@@ -89 +89 @@
         
         if (as_page_fault(page, access, istate) == AS_PF_FAULT) {
-                fault_if_from_uspace(istate, "Page fault: %#x.", page);
+                fault_if_from_uspace(istate, "Page fault: %p.", (void *) page);
                 panic_memtrap(istate, access, page, NULL);
         }
@@ -97 +97 @@
 {
         if (last_frame + ALIGN_UP(size, PAGE_SIZE) > KA2PA(KERNEL_ADDRESS_SPACE_END_ARCH))
-                panic("Unable to map physical memory %p (%" PRIs " bytes).", physaddr,
-                    size);
+                panic("Unable to map physical memory %p (%zu bytes).",
+                    (void *) physaddr, size);
         
         uintptr_t virtaddr = PA2KA(last_frame);

kernel/arch/amd64/src/pm.c

@@ -28 +28 @@
  */
 
-/** @addtogroup amd64   
+/** @addtogroup amd64
  * @{
  */
@@ -52 +52 @@
         { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
         /* KTEXT descriptor */
-        { .limit_0_15  = 0xffff, 
-          .base_0_15   = 0, 
-          .base_16_23  = 0, 
-          .access      = AR_PRESENT | AR_CODE | DPL_KERNEL | AR_READABLE, 
-          .limit_16_19 = 0xf, 
-          .available   = 0, 
-          .longmode    = 1, 
+        { .limit_0_15  = 0xffffU,
+          .base_0_15   = 0,
+          .base_16_23  = 0,
+          .access      = AR_PRESENT | AR_CODE | DPL_KERNEL | AR_READABLE,
+          .limit_16_19 = 0x0fU,
+          .available   = 0,
+          .longmode    = 1,
           .special     = 0,
-          .granularity = 1, 
+          .granularity = 1,
           .base_24_31  = 0 },
         /* KDATA descriptor */
-        { .limit_0_15  = 0xffff, 
-          .base_0_15   = 0, 
-          .base_16_23  = 0, 
-          .access      = AR_PRESENT | AR_DATA | AR_WRITABLE | DPL_KERNEL, 
-          .limit_16_19 = 0xf, 
-          .available   = 0, 
-          .longmode    = 0, 
-          .special     = 0, 
-          .granularity = 1, 
+        { .limit_0_15  = 0xffffU,
+          .base_0_15   = 0,
+          .base_16_23  = 0,
+          .access      = AR_PRESENT | AR_DATA | AR_WRITABLE | DPL_KERNEL,
+          .limit_16_19 = 0x0fU,
+          .available   = 0,
+          .longmode    = 0,
+          .special     = 0,
+          .granularity = 1,
           .base_24_31  = 0 },
         /* UDATA descriptor */
-        { .limit_0_15  = 0xffff, 
-          .base_0_15   = 0, 
-          .base_16_23  = 0, 
-          .access      = AR_PRESENT | AR_DATA | AR_WRITABLE | DPL_USER, 
-          .limit_16_19 = 0xf, 
-          .available   = 0, 
-          .longmode    = 0, 
-          .special     = 1, 
-          .granularity = 1, 
+        { .limit_0_15  = 0xffffU,
+          .base_0_15   = 0,
+          .base_16_23  = 0,
+          .access      = AR_PRESENT | AR_DATA | AR_WRITABLE | DPL_USER,
+          .limit_16_19 = 0x0fU,
+          .available   = 0,
+          .longmode    = 0,
+          .special     = 1,
+          .granularity = 1,
           .base_24_31  = 0 },
         /* UTEXT descriptor */
-        { .limit_0_15  = 0xffff, 
-          .base_0_15   = 0, 
-          .base_16_23  = 0, 
-          .access      = AR_PRESENT | AR_CODE | DPL_USER, 
-          .limit_16_19 = 0xf, 
-          .available   = 0, 
-          .longmode    = 1, 
-          .special     = 0, 
-          .granularity = 1, 
+        { .limit_0_15  = 0xffffU,
+          .base_0_15   = 0,
+          .base_16_23  = 0,
+          .access      = AR_PRESENT | AR_CODE | DPL_USER,
+          .limit_16_19 = 0x0fU,
+          .available   = 0,
+          .longmode    = 1,
+          .special     = 0,
+          .granularity = 1,
           .base_24_31  = 0 },
         /* KTEXT 32-bit protected, for protected mode before long mode */
-        { .limit_0_15  = 0xffff, 
-          .base_0_15   = 0, 
-          .base_16_23  = 0, 
-          .access      = AR_PRESENT | AR_CODE | DPL_KERNEL | AR_READABLE, 
-          .limit_16_19 = 0xf, 
-          .available   = 0, 
-          .longmode    = 0, 
+        { .limit_0_15  = 0xffffU,
+          .base_0_15   = 0,
+          .base_16_23  = 0,
+          .access      = AR_PRESENT | AR_CODE | DPL_KERNEL | AR_READABLE,
+          .limit_16_19 = 0x0fU,
+          .available   = 0,
+          .longmode    = 0,
           .special     = 1,
-          .granularity = 1, 
+          .granularity = 1,
           .base_24_31  = 0 },
         /* TSS descriptor - set up will be completed later,
@@ -111 +111 @@
         { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
         /* VESA Init descriptor */
-#ifdef CONFIG_FB        
-        { 0xffff, 0, VESA_INIT_SEGMENT >> 12, AR_PRESENT | AR_CODE | DPL_KERNEL,
-          0xf, 0, 0, 0, 0, 0
+#ifdef CONFIG_FB
+        {
+                0xffff, 0, VESA_INIT_SEGMENT >> 12, AR_PRESENT | AR_CODE | DPL_KERNEL,
+                    0xf, 0, 0, 0, 0, 0
         }
 #endif
@@ -129 +130 @@
 {
         tss_descriptor_t *td = (tss_descriptor_t *) d;
-
-        td->base_0_15 = base & 0xffff;
-        td->base_16_23 = ((base) >> 16) & 0xff;
-        td->base_24_31 = ((base) >> 24) & 0xff;
+        
+        td->base_0_15 = base & 0xffffU;
+        td->base_16_23 = ((base) >> 16) & 0xffU;
+        td->base_24_31 = ((base) >> 24) & 0xffU;
         td->base_32_63 = ((base) >> 32);
 }
@@ -140 +141 @@
         tss_descriptor_t *td = (tss_descriptor_t *) d;
         
-        td->limit_0_15 = limit & 0xffff;
-        td->limit_16_19 = (limit >> 16) & 0xf;
+        td->limit_0_15 = limit & 0xffffU;
+        td->limit_16_19 = (limit >> 16) & 0x0fU;
 }
 
@@ -149 +150 @@
          * Offset is a linear address.
          */
-        d->offset_0_15 = offset & 0xffff;
-        d->offset_16_31 = offset >> 16 & 0xffff;
+        d->offset_0_15 = offset & 0xffffU;
+        d->offset_16_31 = (offset >> 16) & 0xffffU;
         d->offset_32_63 = offset >> 32;
 }
@@ -165 +166 @@
 {
         idescriptor_t *d;
-        int i;
-
+        unsigned int i;
+        
         for (i = 0; i < IDT_ITEMS; i++) {
                 d = &idt[i];
-
+                
                 d->unused = 0;
                 d->selector = GDT_SELECTOR(KTEXT_DES);
-
+                
                 d->present = 1;
-                d->type = AR_INTERRUPT; /* masking interrupt */
+                d->type = AR_INTERRUPT;  /* masking interrupt */
         }
-
+        
         d = &idt[0];
         idt_setoffset(d++, (uintptr_t) &int_0);