Changeset 774e6d1a in mainline for uspace/lib/c/include/ipc/ip.h

Timestamp:

2011-01-09T23:24:53Z (15 years ago)

Author:

martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4b86dac

Parents:

3c106e88

Message:

partial networking stack overhaul

• a lot of coding style changes (comments, indentation, etc.)
• convert several ints to unsigned ints or size_t values
• streamline many of the IPC-related macros (they no longer dereference the call structure by themselves)
• get rid of netif_interface.h (containing only aliases for remote functions and not serving any purpose)
• rename netif_local.{c|h} to netif_skel.{c|h} (it is really just a skeleton)
• drop the "_remote" and "_standalone" suffixes from most of the netif_ functions (they do not serve any purpose anymore)
• implement netif_client_connection() as a common framework function for all netif modules
  • update the lo module accordingly
• ip module now reports the default gateway to the user whenever it is being set

File:

• uspace/lib/c/include/ipc/ip.h (modified) (2 diffs)

uspace/lib/c/include/ipc/ip.h

@@ -51 +51 @@
          */
         NET_IP_ADD_ROUTE = NET_IP_FIRST,
+        
         /** Gets the actual route information.
          * @see ip_get_route()
          */
         NET_IP_GET_ROUTE,
+        
         /** Processes the received error notification.
          * @see ip_received_error_msg()
          */
         NET_IP_RECEIVED_ERROR,
+        
         /** Sets the default gateway.
          * @see ip_set_default_gateway()
@@ -68 +71 @@
 /*@{*/
 
-/** Returns the address message parameter.
- * @param[in] call The message call structure.
+/** Return the address message parameter.
+ *
+ * @param[in] call Message call structure.
+ *
  */
 #define IP_GET_ADDRESS(call) \
         ({ \
                 in_addr_t addr; \
-                addr.s_addr = IPC_GET_ARG3(*call); \
+                addr.s_addr = IPC_GET_ARG3(call); \
                 addr; \
         })
 
-/** Returns the gateway message parameter.
- * @param[in] call The message call structure.
+/** Return the gateway message parameter.
+ *
+ * @param[in] call Message call structure.
+ *
  */
 #define IP_GET_GATEWAY(call) \
         ({ \
                 in_addr_t addr; \
-                addr.s_addr = IPC_GET_ARG2(*call); \
+                addr.s_addr = IPC_GET_ARG2(call); \
                 addr; \
         })
 
-/** Sets the header length in the message answer.
- * @param[out] answer The message answer structure.
+/** Set the header length in the message answer.
+ *
+ * @param[out] answer Message answer structure.
+ *
  */
-#define IP_SET_HEADERLEN(answer, value) \
-        do { \
-                sysarg_t argument = (sysarg_t) (value); \
-                IPC_SET_ARG2(*answer, argument); \
-        } while (0)
+#define IP_SET_HEADERLEN(answer, value)  IPC_SET_ARG2(answer, (sysarg_t) (value))
 
-/** Returns the network mask message parameter.
- * @param[in] call The message call structure.
+/** Return the network mask message parameter.
+ *
+ * @param[in] call Message call structure.
+ *
  */
 #define IP_GET_NETMASK(call) \
         ({ \
                 in_addr_t addr; \
-                addr.s_addr = IPC_GET_ARG4(*call); \
+                addr.s_addr = IPC_GET_ARG4(call); \
                 addr; \
         })
 
-/** Returns the protocol message parameter.
- * @param[in] call The message call structure.
+/** Return the protocol message parameter.
+ *
+ * @param[in] call Message call structure.
+ *
  */
-#define IP_GET_PROTOCOL(call) \
-        ({ \
-                ip_protocol_t protocol = (ip_protocol_t) IPC_GET_ARG1(*call); \
-                protocol; \
-        })
+#define IP_GET_PROTOCOL(call)  ((ip_protocol_t) IPC_GET_ARG1(call))
 
 /*@}*/