Changeset 7171760 in mainline for uspace/app

Timestamp:

2011-08-18T12:05:00Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b33ec43

Parents:

866e627

Message:

Rework the way how open files are passed from parent task to child.

• Instead of passing fdi_node_t's, pass handles directly using the IPC_M_STATE_CHANGE_AUTHORIZE mechanism.
• Remove open_node(), fd_node(), fdi_node_t.
• Replace fopen_node() with fopen_handle().
• Replace fnode() with fhandle().
• The child task does not synchronize with VFS yet.

Location:

uspace/app

Files:

• bdsh/exec.c (modified) (2 diffs)
• trace/trace.c (modified) (2 diffs)

uspace/app/bdsh/exec.c

@@ -100 +100 @@
         char *tmp;
         int rc, retval, i;
-        fdi_node_t file_nodes[3];
-        fdi_node_t *file_nodes_p[4];
+        int file_handles[3];
+        int *file_handles_p[4];
         FILE *files[3];
 
@@ -112 +112 @@
         
         for (i = 0; i < 3 && files[i] != NULL; i++) {
-                if (fnode(files[i], &file_nodes[i]) == EOK) {
-                        file_nodes_p[i] = &file_nodes[i];
+                if (fhandle(files[i], &file_handles[i]) == EOK) {
+                        file_handles_p[i] = &file_handles[i];
                 }
                 else {
-                        file_nodes_p[i] = NULL;
+                        file_handles_p[i] = NULL;
                 }
         }
-        file_nodes_p[i] = NULL;
+        file_handles_p[i] = NULL;
 
-        rc = task_spawnvf(&tid, tmp, (const char **) argv, file_nodes_p);
+        rc = task_spawnvf(&tid, tmp, (const char **) argv, file_handles_p);
         free(tmp);
 

uspace/app/trace/trace.c

@@ -587 +587 @@
 
         /* Send default files */
-        fdi_node_t *files[4];
-        fdi_node_t stdin_node;
-        fdi_node_t stdout_node;
-        fdi_node_t stderr_node;
-        
-        if ((stdin != NULL) && (fnode(stdin, &stdin_node) == EOK))
-                files[0] = &stdin_node;
+        int *files[4];
+        int fd_stdin;
+        int fd_stdout;
+        int fd_stderr;
+        
+        if ((stdin != NULL) && (fhandle(stdin, &fd_stdin) == EOK))
+                files[0] = &fd_stdin;
         else
                 files[0] = NULL;
         
-        if ((stdout != NULL) && (fnode(stdout, &stdout_node) == EOK))
-                files[1] = &stdout_node;
+        if ((stdout != NULL) && (fhandle(stdout, &fd_stdout) == EOK))
+                files[1] = &fd_stdout;
         else
                 files[1] = NULL;
         
-        if ((stderr != NULL) && (fnode(stderr, &stderr_node) == EOK))
-                files[2] = &stderr_node;
+        if ((stderr != NULL) && (fhandle(stderr, &fd_stderr) == EOK))
+                files[2] = &fd_stderr;
         else
                 files[2] = NULL;
@@ -762 +762 @@
         o = oper_new("open", 2, arg_def, V_INT_ERRNO, 0, resp_def);
         proto_add_oper(p, VFS_IN_OPEN, o);
-        o = oper_new("open_node", 4, arg_def, V_INT_ERRNO, 0, resp_def);
-        proto_add_oper(p, VFS_IN_OPEN_NODE, o);
         o = oper_new("read", 1, arg_def, V_ERRNO, 1, resp_def);
         proto_add_oper(p, VFS_IN_READ, o);