Changeset 6efec7e3 in mainline for uspace/srv/sysman/unit.c

Timestamp:

2019-08-03T07:38:34Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

59ba708

Parents:

4fe7fcb

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-03-17 19:54:13)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-03 07:38:34)

Message:

Unit polymorphism (simple mount), debug logging

File:

• uspace/srv/sysman/unit.c (modified) (5 diffs)

uspace/srv/sysman/unit.c

@@ -6 +6 @@
 #include <stdlib.h>
 
+#include "log.h"
 #include "unit.h"
+
+/** Virtual method table for each unit type */
+static unit_ops_t *unit_type_vmts[] = {
+        [UNIT_TARGET]        = &unit_tgt_ops,
+        [UNIT_MOUNT]         = &unit_mnt_ops,
+        [UNIT_CONFIGURATION] = &unit_cfg_ops
+};
 
 static void unit_init(unit_t *unit, unit_type_t type)
@@ -12 +20 @@
         assert(unit);
 
+        memset(unit, 0, sizeof(unit_t));
         link_initialize(&unit->units);
         
@@ -21 +30 @@
         list_initialize(&unit->dependants);
         list_initialize(&unit->dependencies);
+
+        unit_type_vmts[unit->type]->init(unit);
 }
 
@@ -33 +44 @@
 
 /** Release resources used by unit structure */
-void unit_destroy(unit_t **unit)
+void unit_destroy(unit_t **unit_ptr)
 {
-        if (*unit == NULL)
+        unit_t *unit = *unit_ptr;
+        if (unit == NULL)
                 return;
+
+        unit_type_vmts[unit->type]->destroy(unit);
         /* TODO:
          *      edges,
-         *      specific unit data,
          *      check it's not an active unit,
          *      other resources to come
          */
-        free(*unit);
-        *unit = NULL;
+        free(unit);
+        unit_ptr = NULL;
+}
+
+void unit_set_state(unit_t *unit, unit_state_t state)
+{
+        fibril_mutex_lock(&unit->state_mtx);
+        unit->state = state;
+        fibril_condvar_broadcast(&unit->state_cv);
+        fibril_mutex_unlock(&unit->state_mtx);
 }
 
@@ -54 +75 @@
 int unit_start(unit_t *unit)
 {
-        // TODO actually start the unit
-        printf("Starting unit of type %i\n", unit->type);
-        return EOK;
+        sysman_log(LVL_DEBUG, "%s(%p)", __func__, unit);
+        return unit_type_vmts[unit->type]->start(unit);
 }