Changeset 6d5da743 in mainline for kernel/generic/src/udebug/udebug_ipc.c

Timestamp:

2014-04-25T08:10:14Z (11 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d815b74, fef725d

Parents:

7cd15b9 (diff), 723ce99 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merged random-configuration checking script + few fixes

The main Makefile has a new target - random-config - that generates
a random (but valid) configuration. This is useful for testing non-
default configurations.

The contrib/tools/random_check.sh script then further automates this
process by building random configurations multiple times.

This merge also includes several minor changes that fixed some of
the problems discovered by usage of the above mentioned script.

For the record, following configurations still do not build
(assuming the default platform profile with these alterations):

• ARM 32 - Raspberry Pi
  • without the PL011 UART
  • with framebuffer support but without support of the BCM2835 (this looks like a nonsense configuration that shall be prohibited by the configuration script itself)
• ARM 32 - GTA-02
  • without the S3C24 UART
• ARM 32 - Integrator/CP
  • without PC keyboard
• PowerPC 32
  • with link-time-optimization and -Os
• IA 32
  • when all the dynamic-linking stuff is enabled

[Merged from lp:~vojtech-horky/helenos/misc]

File:

• kernel/generic/src/udebug/udebug_ipc.c (modified) (4 diffs)

kernel/generic/src/udebug/udebug_ipc.c

@@ -343 +343 @@
         sysarg_t uspace_addr;
         sysarg_t to_copy;
-        void *buffer;
+        void *buffer = NULL;
         int rc;
 
@@ -354 +354 @@
                 return;
         }
+
+        ASSERT(buffer != NULL);
 
         /*
@@ -385 +387 @@
         sysarg_t uspace_src;
         unsigned size;
-        void *buffer;
+        void *buffer = NULL;
         int rc;
 
@@ -398 +400 @@
                 return;
         }
+
+        ASSERT(buffer != NULL);
 
         IPC_SET_RETVAL(call->data, 0);