Changeset 623b49f1 in mainline for kernel/arch/ia32xen/src


Ignore:
Timestamp:
2007-01-29T19:22:04Z (18 years ago)
Author:
Martin Decky <martin@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
1004b37
Parents:
7d07bf3
Message:

fix signed/unsigned comparison and integer overflow

Location:
kernel/arch/ia32xen/src/smp
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • kernel/arch/ia32xen/src/smp/apic.c

    r7d07bf3 r623b49f1  
    125125{
    126126        io_apic_id_t idreg;
    127         int i;
     127        unsigned int i;
    128128
    129129        exc_register(VECTOR_APIC_SPUR, "apic_spurious", (iroutine) apic_spurious);
     
    529529{
    530530        io_redirection_reg_t reg;
    531         int i, pin;
    532        
    533         for (i=0;i<16;i++) {
    534                 if (irqmask & (1<<i)) {
     531        unsigned int i;
     532        int pin;
     533       
     534        for (i = 0; i < 16; i++) {
     535                if (irqmask & (1 << i)) {
    535536                        /*
    536537                         * Mask the signal input in IO APIC if there is a
     
    554555void io_apic_enable_irqs(uint16_t irqmask)
    555556{
    556         int i, pin;
     557        unsigned int i;
     558        int pin;
    557559        io_redirection_reg_t reg;       
    558560       
    559         for (i=0;i<16;i++) {
    560                 if (irqmask & (1<<i)) {
     561        for (i = 0; i < 16; i++) {
     562                if (irqmask & (1 << i)) {
    561563                        /*
    562564                         * Unmask the signal input in IO APIC if there is a
  • kernel/arch/ia32xen/src/smp/mps.c

    r7d07bf3 r623b49f1  
    9393static bool is_bsp(index_t i);
    9494static uint8_t get_cpu_apic_id(index_t i);
    95 static int mps_irq_to_pin(int irq);
     95static int mps_irq_to_pin(unsigned int irq);
    9696
    9797struct smp_config_operations mps_config_operations = {
     
    416416}
    417417
    418 int mps_irq_to_pin(int irq)
     418int mps_irq_to_pin(unsigned int irq)
    419419{
    420420        int i;
    421421       
    422         for(i=0;i<io_intr_entry_cnt;i++) {
     422        for (i = 0; i < io_intr_entry_cnt; i++) {
    423423                if (io_intr_entries[i].src_bus_irq == irq && io_intr_entries[i].intr_type == 0)
    424424                        return io_intr_entries[i].dst_io_apic_pin;
  • kernel/arch/ia32xen/src/smp/smp.c

    r7d07bf3 r623b49f1  
    163163}
    164164
    165 int smp_irq_to_pin(int irq)
     165int smp_irq_to_pin(unsigned int irq)
    166166{
    167167        ASSERT(ops != NULL);
Note: See TracChangeset for help on using the changeset viewer.