Changeset 516e780 in mainline for uspace/lib/math/generic/fmod.c

Timestamp:

2018-08-31T11:55:41Z (7 years ago)

Author:

GitHub <noreply@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fa86fff

Parents:

7f7d642

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-08-31 11:55:41)

git-committer:

GitHub <noreply@…> (2018-08-31 11:55:41)

Message:

Strip down libmath. (#45)

libmath is mostly unused (except for trunc(), sin() and cos()), and most functions in it are either very imprecise or downright broken. Additionally, it is implemented in manner that conflicts with C standard. Instead of trying to fix all the shortcomings while maintaining unused functionality, I'm opting to simply remove most of it and only keep the parts that are currently necessary.

Later readdition of the removed functions is possible, but there needs to be a reliable way to evaluate their quality first.

File:

• uspace/lib/math/generic/fmod.c (modified) (3 diffs)

uspace/lib/math/generic/fmod.c

@@ -33 +33 @@
  */
 
-#include <fmod.h>
 #include <math.h>
 
@@ -52 +51 @@
  *
  */
-float32_t float32_fmod(float32_t dividend, float32_t divisor)
+float fmodf(float dividend, float divisor)
 {
         // FIXME: replace with exact arithmetics
 
-        float32_t quotient = trunc_f32(dividend / divisor);
+        float quotient = truncf(dividend / divisor);
 
         return (dividend - quotient * divisor);
@@ -77 +76 @@
  *
  */
-float64_t float64_fmod(float64_t dividend, float64_t divisor)
+double fmod(double dividend, double divisor)
 {
         // FIXME: replace with exact arithmetics
 
-        float64_t quotient = trunc_f64(dividend / divisor);
+        double quotient = trunc(dividend / divisor);
 
         return (dividend - quotient * divisor);