Changeset 4b1c7c6f in mainline for kernel/arch/ia32/src/smp/smp.c

Timestamp:

2018-03-16T20:57:16Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

6be2c13

Parents:

973be387

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:51:59)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:57:16)

Message:

Clean up PAGE_* flags.

Remove "nop flags", they are confusing for readers and any benefit they would
gain in self-documentation they lose in being used inconsistently.

Remove "PAGE_READ", the only place it's used meaningfully is the incomplete
RISC-V implementation, and most call sites assume read is implied.

File:

• kernel/arch/ia32/src/smp/smp.c (modified) (1 diff)

kernel/arch/ia32/src/smp/smp.c

@@ -75 +75 @@
 
         if (config.cpu_count > 1) {
-                l_apic = (uint32_t *) km_map((uintptr_t) l_apic, PAGE_SIZE,
-                    PAGE_WRITE | PAGE_NOT_CACHEABLE);
-                io_apic = (uint32_t *) km_map((uintptr_t) io_apic, PAGE_SIZE,
-                    PAGE_WRITE | PAGE_NOT_CACHEABLE);
+                l_apic = (uint32_t *) km_map((uintptr_t) l_apic,
+                    PAGE_SIZE, PAGE_WRITE);
+                io_apic = (uint32_t *) km_map((uintptr_t) io_apic,
+                    PAGE_SIZE, PAGE_WRITE);
         }
 }