Changeset 476bf2f6 in mainline for uspace/lib/ext4/libext4_directory_index.c

Timestamp:

2012-02-20T17:27:45Z (13 years ago)

Author:

Frantisek Princ <frantisek.princ@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f577058

Parents:

1ebb66f

Message:

duplicate code extraction

File:

• uspace/lib/ext4/libext4_directory_index.c (modified) (1 diff)

uspace/lib/ext4/libext4_directory_index.c

@@ -580 +580 @@
                 }
 
-                // Compute next block index and allocate data block
-                uint64_t parent_size = ext4_inode_get_size(fs->superblock, parent->inode);
-                uint32_t new_block_idx = parent_size / block_size;
-
                 uint32_t fblock;
-                rc = ext4_filesystem_get_inode_data_block_index(fs, parent->inode, new_block_idx, &fblock);
+                rc =  ext4_directory_append_block(fs, parent, &fblock);
                 if (rc != EOK) {
-                        return rc;
-                }
-
-                if (fblock == 0) {
-                        rc =  ext4_balloc_alloc_block(fs, parent, &fblock);
-                        if (rc != EOK) {
-                                return rc;
-                        }
-
-                        rc = ext4_filesystem_set_inode_data_block_index(fs, parent, new_block_idx, fblock);
-                        if (rc != EOK) {
-                                ext4_balloc_free_block(fs, parent, fblock);
-                                return rc;
-                        }
-
-                        parent_size += block_size;
-                        ext4_inode_set_size(parent->inode, parent_size);
-
-                        parent->dirty = true;
+                        // TODO error
                 }