Changeset 46577995 in mainline for uspace/drv/bus/usb/usbmid/main.c

Timestamp:

2018-01-04T20:50:52Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• uspace/drv/bus/usb/usbmid/main.c (modified) (7 diffs)

uspace/drv/bus/usb/usbmid/main.c

@@ -49 +49 @@
  * @return Error code.
  */
-static int usbmid_device_add(usb_device_t *dev)
+static errno_t usbmid_device_add(usb_device_t *dev)
 {
         usb_log_info("Taking care of new MID `%s'.\n", usb_device_get_name(dev));
@@ -61 +61 @@
  * @return Error code.
  */
-static int usbmid_device_remove(usb_device_t *dev)
+static errno_t usbmid_device_remove(usb_device_t *dev)
 {
         assert(dev);
@@ -68 +68 @@
 
         /* Remove ctl function */
-        int ret = ddf_fun_unbind(usb_mid->ctl_fun);
+        errno_t ret = ddf_fun_unbind(usb_mid->ctl_fun);
         if (ret != EOK) {
                 usb_log_error("Failed to unbind USB MID ctl function: %s.\n",
@@ -87 +87 @@
 
                 /* Tell the child to go off-line. */
-                int pret = ddf_fun_offline(iface->fun);
+                errno_t pret = ddf_fun_offline(iface->fun);
                 if (pret != EOK) {
                         usb_log_warning("Failed to turn off child `%s': %s\n",
@@ -110 +110 @@
  * @return Error code.
  */
-static int usbmid_device_gone(usb_device_t *dev)
+static errno_t usbmid_device_gone(usb_device_t *dev)
 {
         assert(dev);
@@ -119 +119 @@
 
         /* Remove ctl function */
-        int ret = ddf_fun_unbind(usb_mid->ctl_fun);
+        errno_t ret = ddf_fun_unbind(usb_mid->ctl_fun);
         if (ret != EOK) {
                 usb_log_error("Failed to unbind USB MID ctl function: %s.\n",
@@ -137 +137 @@
                     ddf_fun_get_name(iface->fun));
 
-                const int pret = usbmid_interface_destroy(iface);
+                const errno_t pret = usbmid_interface_destroy(iface);
                 if (pret != EOK) {
                         usb_log_error("Failed to remove child `%s': %s\n",