Changeset 46577995 in mainline for kernel/generic/src/console/kconsole.c

Timestamp:

2018-01-04T20:50:52Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• kernel/generic/src/console/kconsole.c (modified) (2 diffs)

kernel/generic/src/console/kconsole.c

@@ -563 +563 @@
                 
                 uintptr_t symaddr;
-                int rc = symtab_addr_lookup(symname, &symaddr);
-                switch (rc) {
-                case ENOENT:
+                errno_t rc = symtab_addr_lookup(symname, &symaddr);
+                switch ((case_errno_t) rc) {
+                case (case_errno_t) ENOENT:
                         printf("Symbol %s not found.\n", symname);
                         return false;
-                case EOVERFLOW:
+                case (case_errno_t) EOVERFLOW:
                         printf("Duplicate symbol %s.\n", symname);
                         symtab_print_search(symname);
                         return false;
-                case ENOTSUP:
+                case (case_errno_t) ENOTSUP:
                         printf("No symbol information available.\n");
                         return false;
-                case EOK:
+                case (case_errno_t) EOK:
                         if (isaddr)
                                 *result = (sysarg_t) symaddr;
@@ -591 +591 @@
                 uint64_t value;
                 char *end;
-                int rc = str_uint64_t(text, &end, 0, false, &value);
+                errno_t rc = str_uint64_t(text, &end, 0, false, &value);
                 if (end != text + len)
                         rc = EINVAL;
-                switch (rc) {
-                case EINVAL:
+                switch ((case_errno_t) rc) {
+                case (case_errno_t) EINVAL:
                         printf("Invalid number '%s'.\n", text);
                         return false;
-                case EOVERFLOW:
+                case (case_errno_t) EOVERFLOW:
                         printf("Integer overflow in '%s'.\n", text);
                         return false;
-                case EOK:
+                case (case_errno_t) EOK:
                         *result = (sysarg_t) value;
                         if (isptr)