Changeset 3bd74758 in mainline for uspace/app/perf/ipc/ns_ping.c

Timestamp:

2018-12-28T09:32:11Z (7 years ago)

Author:

Vojtech Horky <vojtech.horky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c7de81b

Parents:

8ee106b

Message:

perf: huge refactoring

The overall aim of this refactoring was to remove duplicate code in all
benchmarks that was responsible (a) for computing proper workload size
and (b) for computing final statistics.

After the refactoring, the actual benchmark code is quite short and
takes care of the actual work only.

The harness code was factored out into perf.c that is now responsible
for computing the workload size and then runs the actual benchmark.

As an extra feature, we pass stopwatch_t into the benchmark code that is
only responsible for starting/stopping. Duration is then queried outside
the benchmark code.

File:

• uspace/app/perf/ipc/ns_ping.c (modified) (1 diff)

uspace/app/perf/ipc/ns_ping.c

@@ -27 +27 @@
  */
 
-#include <math.h>
 #include <stdio.h>
-#include <stdlib.h>
-#include <time.h>
 #include <ns.h>
 #include <async.h>
 #include <errno.h>
+#include <str_error.h>
 #include "../perf.h"
 
-#define MIN_DURATION_SECS  10
-#define NUM_SAMPLES 10
+bool bench_ns_ping(stopwatch_t *stopwatch, uint64_t niter,
+    char *error, size_t error_size)
+{
+        stopwatch_start(stopwatch);
 
-static errno_t ping_pong_measure(uint64_t niter, uint64_t *rduration)
-{
-        struct timespec start;
-        uint64_t count;
+        for (uint64_t count = 0; count < niter; count++) {
+                errno_t rc = ns_ping();
 
-        getuptime(&start);
-
-        for (count = 0; count < niter; count++) {
-                errno_t retval = ns_ping();
-
-                if (retval != EOK) {
-                        printf("Error sending ping message.\n");
-                        return EIO;
+                if (rc != EOK) {
+                        snprintf(error, error_size,
+                            "failed sending ping message: %s (%d)",
+                            str_error(rc), rc);
+                        return false;
                 }
         }
 
-        struct timespec now;
-        getuptime(&now);
+        stopwatch_stop(stopwatch);
 
-        *rduration = ts_sub_diff(&now, &start) / 1000;
-        return EOK;
+        return true;
 }
-
-static void ping_pong_report(uint64_t niter, uint64_t duration)
-{
-        printf("Completed %" PRIu64 " round trips in %" PRIu64 " us",
-            niter, duration);
-
-        if (duration > 0) {
-                printf(", %" PRIu64 " rt/s.\n", niter * 1000 * 1000 / duration);
-        } else {
-                printf(".\n");
-        }
-}
-
-const char *bench_ns_ping(void)
-{
-        errno_t rc;
-        uint64_t duration;
-        uint64_t dsmp[NUM_SAMPLES];
-
-        printf("Warm up and determine work size...\n");
-
-        struct timespec start;
-        getuptime(&start);
-
-        uint64_t niter = 1;
-
-        while (true) {
-                rc = ping_pong_measure(niter, &duration);
-                if (rc != EOK)
-                        return "Failed.";
-
-                ping_pong_report(niter, duration);
-
-                if (duration >= MIN_DURATION_SECS * 1000000)
-                        break;
-
-                niter *= 2;
-        }
-
-        printf("Measure %d samples...\n", NUM_SAMPLES);
-
-        int i;
-
-        for (i = 0; i < NUM_SAMPLES; i++) {
-                rc = ping_pong_measure(niter, &dsmp[i]);
-                if (rc != EOK)
-                        return "Failed.";
-
-                ping_pong_report(niter, dsmp[i]);
-        }
-
-        double sum = 0.0;
-
-        for (i = 0; i < NUM_SAMPLES; i++)
-                sum += (double)niter / ((double)dsmp[i] / 1000000.0l);
-
-        double avg = sum / NUM_SAMPLES;
-
-        double qd = 0.0;
-        double d;
-        for (i = 0; i < NUM_SAMPLES; i++) {
-                d = (double)niter / ((double)dsmp[i] / 1000000.0l) - avg;
-                qd += d * d;
-        }
-
-        double stddev = qd / (NUM_SAMPLES - 1); // XXX sqrt
-
-        printf("Average: %.0f rt/s Std.dev^2: %.0f rt/s Samples: %d\n",
-            avg, stddev, NUM_SAMPLES);
-
-        return NULL;
-}