Changeset 1569a9b in mainline for uspace/lib/http/src/request.c

Timestamp:

2017-12-24T16:40:33Z (8 years ago)

Author:

GitHub <noreply@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

48fd597

Parents:

a1026da

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-24 16:40:33)

git-committer:

GitHub <noreply@…> (2017-12-24 16:40:33)

Message:

The "not-so-obvious" error handling tweaks. (#9)

Some more changes to enable type-checking with errno_t. Some of the "fixes" here don't quite feel right, but a proper solution would be a more elaborate refactoring of the surrounding code.

File:

• uspace/lib/http/src/request.c (modified) (4 diffs)

uspace/lib/http/src/request.c

@@ -96 +96 @@
         ssize_t meth_size = http_encode_method(NULL, 0, req->method, req->path);
         if (meth_size < 0)
-                return meth_size;
+                return EINVAL;
         size_t size = meth_size;
         
@@ -102 +102 @@
                 ssize_t header_size = http_header_encode(header, NULL, 0);
                 if (header_size < 0)
-                        return header_size;
+                        return EINVAL;
                 size += header_size;
         }
@@ -116 +116 @@
         if (written < 0) {
                 free(buf);
-                return written;
+                return EINVAL;
         }
         pos += written;
@@ -125 +125 @@
                 if (written < 0) {
                         free(buf);
-                        return written;
+                        return EINVAL;
                 }
                 pos += written;