Changeset 05e2a7ad in mainline for generic/include

Timestamp:

2005-12-07T13:32:31Z (20 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

839470f

Parents:

253f8590

Message:

Add comments describing locking rules for some locks.
Cleanup.

Location:

generic/include

Files:

• proc/thread.h (modified) (2 diffs)
• synch/waitq.h (modified) (2 diffs)

generic/include/proc/thread.h

@@ -65 +65 @@
         link_t threads_link;                    /**< Link to the list of all threads. */
         
-        /* items below are protected by lock */
+        /** Lock protecting thread structure.
+         *
+         * Protects the whole thread structure except list links above.
+         * Must be acquired before T.lock for each T of type task_t.
+         * 
+         */
         spinlock_t lock;
 
@@ -110 +115 @@
 };
 
-extern spinlock_t threads_lock;                 /**< Lock protecting threads_head list. */
+/** Thread list lock.
+ *
+ * This lock protects all link_t structures chained in threads_head.
+ * Must be acquired before T.lock for each T of type thread_t.
+ *
+ */
+extern spinlock_t threads_lock;
+
 extern link_t threads_head;                     /**< List of all threads in the system. */
 

generic/include/synch/waitq.h

@@ -39 +39 @@
 #define WAKEUP_ALL      1
 
+/** Wait queue structure. */
 struct waitq {
+
+        /** Lock protecting wait queue structure.
+         *
+         * Must be acquired before T.lock for each T of type thread_t.
+         */
         spinlock_t lock;
+
         int missed_wakeups;     /**< Number of waitq_wakeup() calls that didn't find a thread to wake up. */
         link_t head;            /**< List of sleeping threads for wich there was no missed_wakeup. */
@@ -52 +59 @@
 extern void waitq_initialize(waitq_t *wq);
 extern int waitq_sleep_timeout(waitq_t *wq, __u32 usec, int nonblocking);
-extern void waitq_wakeup(waitq_t *wq, int all);
-extern void _waitq_wakeup_unsafe(waitq_t *wq, int all);
+extern void waitq_wakeup(waitq_t *wq, bool all);
+extern void _waitq_wakeup_unsafe(waitq_t *wq, bool all);
 
 #endif