source: mainline/kernel/generic/src/synch/condvar.c@ 497bd656

lfn serial ticket/834-toolchain-update topic/msim-upgrade topic/simplify-dev-export
Last change on this file since 497bd656 was 497bd656, checked in by Adam Hraska <adam.hraska+hos@…>, 13 years ago

Fix: averted a possible deadlock in condvar_wait_timeout() (eg when a thread has been interrupted and calls the function concurrently with another thread contending the mutex). Locking discipline: lock the mutex before the waitq.

  • Property mode set to 100644
File size: 5.7 KB
Line 
1/*
2 * Copyright (c) 2001-2004 Jakub Jermar
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 *
9 * - Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer.
11 * - Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 * - The name of the author may not be used to endorse or promote products
15 * derived from this software without specific prior written permission.
16 *
17 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
18 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
19 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
20 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
21 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
22 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */
28
29/** @addtogroup sync
30 * @{
31 */
32
33/**
34 * @file
35 * @brief Condition variables.
36 */
37
38#include <synch/condvar.h>
39#include <synch/mutex.h>
40#include <synch/spinlock.h>
41#include <synch/waitq.h>
42#include <arch.h>
43
44/** Initialize condition variable.
45 *
46 * @param cv Condition variable.
47 */
48void condvar_initialize(condvar_t *cv)
49{
50 waitq_initialize(&cv->wq);
51}
52
53/** Signal the condition has become true to the first waiting thread by waking
54 * it up.
55 *
56 * @param cv Condition variable.
57 */
58void condvar_signal(condvar_t *cv)
59{
60 waitq_wakeup(&cv->wq, WAKEUP_FIRST);
61}
62
63/** Signal the condition has become true to all waiting threads by waking
64 * them up.
65 *
66 * @param cv Condition variable.
67 */
68void condvar_broadcast(condvar_t *cv)
69{
70 waitq_wakeup(&cv->wq, WAKEUP_ALL);
71}
72
73/** Wait for the condition becoming true.
74 *
75 * @param cv Condition variable.
76 * @param mtx Mutex.
77 * @param usec Timeout value in microseconds.
78 * @param flags Select mode of operation.
79 *
80 * For exact description of meaning of possible combinations of usec and flags,
81 * see comment for waitq_sleep_timeout(). Note that when
82 * SYNCH_FLAGS_NON_BLOCKING is specified here, ESYNCH_WOULD_BLOCK is always
83 * returned.
84 *
85 * @return See comment for waitq_sleep_timeout().
86 */
87int _condvar_wait_timeout(condvar_t *cv, mutex_t *mtx, uint32_t usec, int flags)
88{
89 int rc;
90 ipl_t ipl;
91
92 ipl = waitq_sleep_prepare(&cv->wq);
93 /* Unlock only after the waitq is locked so we don't miss a wakeup. */
94 mutex_unlock(mtx);
95
96 cv->wq.missed_wakeups = 0; /* Enforce blocking. */
97 rc = waitq_sleep_timeout_unsafe(&cv->wq, usec, flags);
98
99 waitq_sleep_finish(&cv->wq, rc, ipl);
100 /* Lock only after releasing the waitq to avoid a possible deadlock. */
101 mutex_lock(mtx);
102
103 return rc;
104}
105
106/** Wait for the condition to become true with a locked spinlock.
107 *
108 * The function is not aware of irq_spinlock. Therefore do not even
109 * try passing irq_spinlock_t to it. Use _condvar_wait_timeout_irq_spinlock()
110 * instead.
111 *
112 * @param cv Condition variable.
113 * @param lock Locked spinlock.
114 * @param usec Timeout value in microseconds.
115 * @param flags Select mode of operation.
116 *
117 * For exact description of meaning of possible combinations of usec and flags,
118 * see comment for waitq_sleep_timeout(). Note that when
119 * SYNCH_FLAGS_NON_BLOCKING is specified here, ESYNCH_WOULD_BLOCK is always
120 * returned.
121 *
122 * @return See comment for waitq_sleep_timeout().
123 */
124int _condvar_wait_timeout_spinlock_impl(condvar_t *cv, spinlock_t *lock,
125 uint32_t usec, int flags)
126{
127 int rc;
128 ipl_t ipl;
129
130 ipl = waitq_sleep_prepare(&cv->wq);
131
132 /* Unlock only after the waitq is locked so we don't miss a wakeup. */
133 spinlock_unlock(lock);
134
135 cv->wq.missed_wakeups = 0; /* Enforce blocking. */
136 rc = waitq_sleep_timeout_unsafe(&cv->wq, usec, flags);
137
138 waitq_sleep_finish(&cv->wq, rc, ipl);
139 /* Lock only after releasing the waitq to avoid a possible deadlock. */
140 spinlock_lock(lock);
141
142 return rc;
143}
144
145/** Wait for the condition to become true with a locked irq spinlock.
146 *
147 * @param cv Condition variable.
148 * @param lock Locked irq spinlock.
149 * @param usec Timeout value in microseconds.
150 * @param flags Select mode of operation.
151 *
152 * For exact description of meaning of possible combinations of usec and flags,
153 * see comment for waitq_sleep_timeout(). Note that when
154 * SYNCH_FLAGS_NON_BLOCKING is specified here, ESYNCH_WOULD_BLOCK is always
155 * returned.
156 *
157 * @return See comment for waitq_sleep_timeout().
158 */
159int _condvar_wait_timeout_irq_spinlock(condvar_t *cv, irq_spinlock_t *irq_lock,
160 uint32_t usec, int flags)
161{
162 int rc;
163 /* Save spinlock's state so we can restore it correctly later on. */
164 ipl_t ipl = irq_lock->ipl;
165 bool guard = irq_lock->guard;
166
167 irq_lock->guard = false;
168
169 /*
170 * waitq_prepare() restores interrupts to the current state,
171 * ie disabled. Therefore, interrupts will remain disabled while
172 * it spins waiting for a pending timeout handler to complete.
173 * Although it spins with interrupts disabled there can only
174 * be a pending timeout if we failed to cancel an imminent
175 * timeout (on another cpu) during a wakeup. As a result the
176 * timeout handler is guaranteed to run (it is most likely already
177 * running) and there is no danger of a deadlock.
178 */
179 rc = _condvar_wait_timeout_spinlock(cv, &irq_lock->lock, usec, flags);
180
181 irq_lock->guard = guard;
182 irq_lock->ipl = ipl;
183
184 return rc;
185}
186
187
188/** @}
189 */
Note: See TracBrowser for help on using the repository browser.