source: mainline/kernel/generic/src/ipc/ops/concttome.c@ 3be9d10

lfn serial ticket/834-toolchain-update topic/msim-upgrade topic/simplify-dev-export
Last change on this file since 3be9d10 was eadaeae8, checked in by Jakub Jermar <jakub@…>, 8 years ago

Make capability handles type-safe

Define distinct pointer types for the handles of the supported
capability types and use them instead of integer handles. This makes it
virtually impossible to pass a non-handle or a handle of different type
instead of the proper handle. Also turn cap_handle_t into an "untyped"
capability handle that can be assigned to and from the "typed" handles.

This commit also fixes a bug in msim-con driver, which wrongly used the
IRQ number instead of the IRQ capability handle to unregister the IRQ.

This commit also fixes the wrong use of the capability handle instead
of error code in libusbhost.

  • Property mode set to 100644
File size: 3.6 KB
Line 
1/*
2 * Copyright (c) 2006 Ondrej Palkovsky
3 * Copyright (c) 2012 Jakub Jermar
4 * All rights reserved.
5 *
6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions
8 * are met:
9 *
10 * - Redistributions of source code must retain the above copyright
11 * notice, this list of conditions and the following disclaimer.
12 * - Redistributions in binary form must reproduce the above copyright
13 * notice, this list of conditions and the following disclaimer in the
14 * documentation and/or other materials provided with the distribution.
15 * - The name of the author may not be used to endorse or promote products
16 * derived from this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
19 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
20 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
21 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
22 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
23 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */
29
30/** @addtogroup genericipc
31 * @{
32 */
33/** @file
34 */
35
36#include <ipc/sysipc_ops.h>
37#include <ipc/ipc.h>
38#include <ipc/ipcrsc.h>
39#include <abi/errno.h>
40#include <arch.h>
41
42static int request_process(call_t *call, answerbox_t *box)
43{
44 cap_phone_handle_t phone_handle;
45 kobject_t *phone_obj;
46 errno_t rc = phone_alloc(TASK, false, &phone_handle, &phone_obj);
47 call->priv = (sysarg_t) phone_obj;
48 IPC_SET_ARG5(call->data,
49 (rc == EOK) ? CAP_HANDLE_RAW(phone_handle) : CAP_NIL);
50 return 0;
51}
52
53static errno_t answer_cleanup(call_t *answer, ipc_data_t *olddata)
54{
55 cap_phone_handle_t phone_handle = (cap_handle_t) IPC_GET_ARG5(*olddata);
56 kobject_t *phone_obj = (kobject_t *) answer->priv;
57
58 if (CAP_HANDLE_VALID(phone_handle)) {
59 kobject_put(phone_obj);
60 cap_free(TASK, phone_handle);
61 }
62
63 return EOK;
64}
65
66static errno_t answer_preprocess(call_t *answer, ipc_data_t *olddata)
67{
68 cap_phone_handle_t phone_handle = (cap_handle_t) IPC_GET_ARG5(*olddata);
69 kobject_t *phone_obj = (kobject_t *) answer->priv;
70
71 if (IPC_GET_RETVAL(answer->data) != EOK) {
72 /* The connection was not accepted */
73 answer_cleanup(answer, olddata);
74 } else if (CAP_HANDLE_VALID(phone_handle)) {
75 /*
76 * The connection was accepted
77 */
78
79 /*
80 * We need to create another reference as the one we have now
81 * will be consumed by ipc_phone_connect().
82 */
83 kobject_add_ref(phone_obj);
84
85 if (ipc_phone_connect(phone_obj->phone,
86 &answer->sender->answerbox)) {
87 /* Pass the reference to the capability */
88 cap_publish(TASK, phone_handle, phone_obj);
89 /* Set 'phone hash' as ARG5 of response */
90 IPC_SET_ARG5(answer->data,
91 (sysarg_t) phone_obj->phone);
92 } else {
93 /* The answerbox is shutting down. */
94 IPC_SET_RETVAL(answer->data, ENOENT);
95 answer_cleanup(answer, olddata);
96 }
97 } else {
98 IPC_SET_RETVAL(answer->data, ELIMIT);
99 }
100
101 return EOK;
102}
103
104
105sysipc_ops_t ipc_m_connect_to_me_ops = {
106 .request_preprocess = null_request_preprocess,
107 .request_forget = null_request_forget,
108 .request_process = request_process,
109 .answer_cleanup = answer_cleanup,
110 .answer_preprocess = answer_preprocess,
111 .answer_process = null_answer_process,
112};
113
114/** @}
115 */
Note: See TracBrowser for help on using the repository browser.