Changeset fd67c9f in mainline for kernel/arch/mips32/src/mach/malta/malta.c

Timestamp:

2019-04-06T08:10:27Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

534bcdf

Parents:

ef56a43

Message:

Handle PIC spurious IRQs with care

File:

• kernel/arch/mips32/src/mach/malta/malta.c (modified) (2 diffs)

kernel/arch/mips32/src/mach/malta/malta.c

@@ -74 +74 @@
 {
         uint8_t isa_irq = host2uint32_t_le(pio_read_32(GT64120_PCI0_INTACK));
-        if (isa_irq == PIC0_SPURIOUS_IRQ || isa_irq == PIC1_SPURIOUS_IRQ) {
-                /*
-                 * XXX: Examine ISR to figure out whether this is indeed a
-                 *      spurious or actual IRQ.
-                 */
+        if (pic_is_spurious(isa_irq)) {
+                pic_handle_spurious(isa_irq);
 #ifdef CONFIG_DEBUG
-                log(LF_ARCH, LVL_DEBUG, "cpu%u: PIC spurious interrupt",
-                    CPU->id);
+                log(LF_ARCH, LVL_DEBUG, "cpu%u: PIC spurious interrupt %u",
+                    CPU->id, isa_irq);
                 return;
 #endif
@@ -91 +88 @@
         } else {
 #ifdef CONFIG_DEBUG
-                log(LF_ARCH, LVL_DEBUG, "cpu%u: spurious IRQ (irq=%u)",
+                log(LF_ARCH, LVL_DEBUG, "cpu%u: unhandled IRQ (irq=%u)",
                     CPU->id, isa_irq);
 #endif