Changeset f9d0a86 in mainline for uspace/lib/c/generic/loc.c

Timestamp:

2017-11-14T12:24:42Z (8 years ago)

Author:

Aearsis <Hlavaty.Ondrej@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6cad776

Parents:

887c9de (diff), d2d142a (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Aearsis <Hlavaty.Ondrej@…> (2017-11-14 01:04:19)

git-committer:

Aearsis <Hlavaty.Ondrej@…> (2017-11-14 12:24:42)

Message:

Merge tag '0.7.1'

The merge wasn't clean, because of changes in build system. The most
significant change was partial revert of usbhc callback refactoring,
which now does not take usb transfer batch, but few named fields again.

File:

• uspace/lib/c/generic/loc.c (modified) (3 diffs)

uspace/lib/c/generic/loc.c

@@ -247 +247 @@
         sysarg_t retval = async_data_write_start(exch, name, str_size(name));
         
-        loc_exchange_end(exch);
-        
         if (retval != EOK) {
                 async_forget(req);
-                return retval;
-        }
-        
-        exch = loc_exchange_begin(INTERFACE_LOC_SUPPLIER);
+                loc_exchange_end(exch);
+                return retval;
+        }
+        
         async_connect_to_me(exch, 0, 0, 0);
-        loc_exchange_end(exch);
-        
+
+        /*
+         * First wait for the answer and then end the exchange. The opposite
+         * order is generally wrong because it may lead to a deadlock under
+         * certain circumstances.
+         */
         async_wait_for(req, &retval);
+        loc_exchange_end(exch);
+        
         return retval;
 }
@@ -276 +280 @@
         sysarg_t retval = async_data_write_start(exch, fqsn, str_size(fqsn));
         
-        
         if (retval != EOK) {
                 async_forget(req);
@@ -283 +286 @@
         }
         
+        /*
+         * First wait for the answer and then end the exchange. The opposite
+         * order is generally wrong because it may lead to a deadlock under
+         * certain circumstances.
+         */
         async_wait_for(req, &retval);
         loc_exchange_end(exch);